Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 496903002: Provide core API permissions to extensions_unittests (Closed)

Created:
6 years, 4 months ago by James Cook
Modified:
6 years, 4 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Provide core API permissions to extensions_unittests This will make it easier to move tests that use permissions from Chrome's unit_tests target to extensions_unittests. BUG=none TEST=extensions_unittests passes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M extensions/test/test_extensions_client.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
James Cook
yoz, PTAL
6 years, 4 months ago (2014-08-21 23:10:10 UTC) #1
Yoyo Zhou
LGTM
6 years, 4 months ago (2014-08-21 23:44:08 UTC) #2
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-21 23:48:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/496903002/1
6 years, 4 months ago (2014-08-21 23:49:27 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 00:54:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 01:00:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8293)
6 years, 4 months ago (2014-08-22 01:00:47 UTC) #7
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-22 01:31:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/496903002/1
6 years, 4 months ago (2014-08-22 01:34:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (1) as 291313
6 years, 4 months ago (2014-08-22 01:56:32 UTC) #10
James Cook
6 years, 4 months ago (2014-08-22 02:00:10 UTC) #11
Message was sent while issue was closed.
tfarina, this might make it easier to move tests under extensions/common -- if
there were tests dying because they couldn't find permissions this might make
them work (at least if they are looking for dns, power, serial, socket, or usb
permissions).

Powered by Google App Engine
This is Rietveld 408576698