extensions/browser/guest_view/web_view/javascript_dialog_helper.cc - Issue 496873006: Move core web_view code to extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

Issue 496873006: Move core web_view code to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove dependency of web_view_internal_api.h Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

diff --git a/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

similarity index 89%

rename from chrome/browser/guest_view/web_view/javascript_dialog_helper.cc

rename to extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

index 6fe90b1b4f45c78269151998d03e549e4372210a..1ee2f7f4eb82d97aee60e4bbce3435fd59b1f2d8 100644

--- a/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc

+++ b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

@@ -2,15 +2,15 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "chrome/browser/guest_view/web_view/javascript_dialog_helper.h"

+#include "extensions/browser/guest_view/web_view/javascript_dialog_helper.h"

#include "base/strings/utf_string_conversions.h"

#include "base/values.h"

-#include "chrome/browser/guest_view/web_view/web_view_constants.h"

-#include "chrome/browser/guest_view/web_view/web_view_guest.h"

-#include "chrome/browser/guest_view/web_view/web_view_permission_helper.h"

-#include "chrome/browser/guest_view/web_view/web_view_permission_types.h"

#include "extensions/browser/guest_view/guest_view_constants.h"

+#include "extensions/browser/guest_view/web_view/web_view_constants.h"

+#include "extensions/browser/guest_view/web_view/web_view_guest.h"

+#include "extensions/browser/guest_view/web_view/web_view_permission_helper.h"

+#include "extensions/browser/guest_view/web_view/web_view_permission_types.h"

namespace extensions {