Move core web_view code to extensions.

extensions/extensions.gyp

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'targets': [
     {
@@ skipping 442 matching lines @@
         'browser/extension_system_provider.h',
         'browser/extension_util.cc',
         'browser/extension_util.h',
         'browser/extension_web_contents_observer.cc',
         'browser/extension_web_contents_observer.h',
         'browser/extensions_browser_client.cc',
         'browser/extensions_browser_client.h',
         'browser/external_provider_interface.h',
         'browser/granted_file_entry.cc',
         'browser/granted_file_entry.h',
+        'browser/guest_view/app_view/app_view_constants.cc',
+        'browser/guest_view/app_view/app_view_constants.h',
+        'browser/guest_view/app_view/app_view_guest.cc',
+        'browser/guest_view/app_view/app_view_guest.h',
+        'browser/guest_view/app_view/app_view_guest_delegate.cc',
+        'browser/guest_view/app_view/app_view_guest_delegate.h',
         'browser/guest_view/guest_view_base.cc',
         'browser/guest_view/guest_view_base.h',
         'browser/guest_view/guest_view_constants.cc',
         'browser/guest_view/guest_view_constants.h',
         'browser/guest_view/guest_view_manager_factory.h',
         'browser/guest_view/guest_view_manager.cc',
         'browser/guest_view/guest_view_manager.h',
         'browser/guest_view/guest_view.h',
-        'browser/guest_view/app_view/app_view_constants.cc',
-        'browser/guest_view/app_view/app_view_constants.h',
-        'browser/guest_view/app_view/app_view_guest.cc',
-        'browser/guest_view/app_view/app_view_guest.h',
-        'browser/guest_view/app_view/app_view_guest_delegate.cc',
-        'browser/guest_view/app_view/app_view_guest_delegate.h',
+        'browser/guest_view/web_view/javascript_dialog_helper.cc',
+        'browser/guest_view/web_view/javascript_dialog_helper.h',
+        'browser/guest_view/web_view/web_view_constants.cc',
+        'browser/guest_view/web_view/web_view_constants.h',
+        'browser/guest_view/web_view/web_view_find_helper.cc',
+        'browser/guest_view/web_view/web_view_find_helper.h',
+        'browser/guest_view/web_view/web_view_guest.cc',

[jamesr, 2014/08/25 22:48:55]

this file #includes headers from chrome/browser/.  those headers in turn
#include files from chrome/common/ that depend on generated headers.  this
target needs to declare its dependency on chrome/browser/ and chrome/browser
needs to export_dependent_settings from common in order to forward the hard
dependency on the target that generates chrome/common/extensions/api/types.h

it doesn't really seem right for code in src/extensions/ and src/chrome/ to both
be #including each other, though.  one or the other is wrong...

+        'browser/guest_view/web_view/web_view_guest.h',
+        'browser/guest_view/web_view/web_view_guest_delegate.cc',
+        'browser/guest_view/web_view/web_view_guest_delegate.h',
+        'browser/guest_view/web_view/web_view_permission_types.h',
+        'browser/guest_view/web_view/web_view_permission_helper.cc',
+        'browser/guest_view/web_view/web_view_permission_helper.h',
         'browser/guest_view/web_view/web_view_permission_helper_delegate.cc',
         'browser/guest_view/web_view/web_view_permission_helper_delegate.h',
-        'browser/guest_view/web_view/web_view_guest_delegate.cc',
-        'browser/guest_view/web_view/web_view_guest_delegate.h',
+        'browser/guest_view/web_view/web_view_renderer_state.cc',
+        'browser/guest_view/web_view/web_view_renderer_state.h',
         'browser/image_loader.cc',
         'browser/image_loader.h',
         'browser/image_loader_factory.cc',
         'browser/image_loader_factory.h',
         'browser/image_util.cc',
         'browser/image_util.h',
         'browser/info_map.cc',
         'browser/info_map.h',
         'browser/install_flag.h',
         'browser/file_highlighter.cc',
@@ skipping 465 matching lines @@
           'browser/api/cast_channel/logging.proto'
       ],
       'variables': {
           'proto_in_dir': 'browser/api/cast_channel',
           'proto_out_dir': 'extensions/browser/api/cast_channel',
       },
       'includes': [ '../build/protoc.gypi' ]
     },
   ]
 }