extensions/browser/guest_view/DEPS - Issue 496873006: Move core web_view code to extensions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/browser/guest_view/DEPS

Issue 496873006: Move core web_view code to extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 # TODO(hanxi): Remove these. http://crbug.com/352293.

	3 "+chrome/browser/extensions/api/web_view/web_view_internal_api.h",

	4 "+third_party/WebKit/public/web/WebFindOptions.h",
	Fady Samuel 2014/08/25 14:22:52 Xi, is it possible for us to find ways to avoid th Xi, is it possible for us to find ways to avoid these dependencies all together? Xi Han 2014/08/25 17:20:20 The WebViewFindHelper still needs to include WebFi Show quoted text On 2014/08/25 14:22:52, Fady Samuel wrote: > Xi, is it possible for us to find ways to avoid these dependencies all together? The WebViewFindHelper still needs to include WebFindOptions.h; WebViewGuest.cc needs to include web_view_internal_api.h. Currently we still needs them.
	5 ]

OLD	NEW