Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Side by Side Diff: PRESUBMIT.py

Issue 496873002: Use android_dbg_tests_recipe for manual try jobs instead of android_dbg & android_dbg_triggered_… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 1477 matching lines...) Expand 10 before | Expand all | Expand 10 after
1488 # TODO(maruel): Figure out a way to run 'sizes' where people can 1488 # TODO(maruel): Figure out a way to run 'sizes' where people can
1489 # effectively update the perf expectation correctly. This requires a 1489 # effectively update the perf expectation correctly. This requires a
1490 # clobber=True build running 'sizes'. 'sizes' is not accurate with 1490 # clobber=True build running 'sizes'. 'sizes' is not accurate with
1491 # incremental build. Reference: 1491 # incremental build. Reference:
1492 # http://chromium.org/developers/tree-sheriffs/perf-sheriffs. 1492 # http://chromium.org/developers/tree-sheriffs/perf-sheriffs.
1493 # TODO(maruel): An option would be to run 'sizes' but not count a failure 1493 # TODO(maruel): An option would be to run 'sizes' but not count a failure
1494 # of this step as a try job failure. 1494 # of this step as a try job failure.
1495 'android_aosp': ['compile'], 1495 'android_aosp': ['compile'],
1496 'android_chromium_gn_compile_rel': ['compile'], 1496 'android_chromium_gn_compile_rel': ['compile'],
1497 'android_clang_dbg': ['slave_steps'], 1497 'android_clang_dbg': ['slave_steps'],
1498 'android_dbg': ['slave_steps'], 1498 'android_dbg_tests_recipe': ['slave_steps'],
1499 'cros_x86': ['defaulttests'], 1499 'cros_x86': ['defaulttests'],
1500 'ios_dbg_simulator': [ 1500 'ios_dbg_simulator': [
1501 'compile', 1501 'compile',
1502 'base_unittests', 1502 'base_unittests',
1503 'content_unittests', 1503 'content_unittests',
1504 'crypto_unittests', 1504 'crypto_unittests',
1505 'url_unittests', 1505 'url_unittests',
1506 'net_unittests', 1506 'net_unittests',
1507 'sql_unittests', 1507 'sql_unittests',
1508 'ui_unittests', 1508 'ui_unittests',
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
1581 ]) 1581 ])
1582 if all(re.search('(^|[/_])win[/_.]', f) for f in files): 1582 if all(re.search('(^|[/_])win[/_.]', f) for f in files):
1583 return GetDefaultTryConfigs([ 1583 return GetDefaultTryConfigs([
1584 'win_chromium_dbg', 1584 'win_chromium_dbg',
1585 'win_chromium_rel_swarming', 1585 'win_chromium_rel_swarming',
1586 ]) 1586 ])
1587 if all(re.search('(^|[/_])android[/_.]', f) for f in files): 1587 if all(re.search('(^|[/_])android[/_.]', f) for f in files):
1588 return GetDefaultTryConfigs([ 1588 return GetDefaultTryConfigs([
1589 'android_aosp', 1589 'android_aosp',
1590 'android_clang_dbg', 1590 'android_clang_dbg',
1591 'android_dbg', 1591 'android_dbg_tests_recipe',
1592 ]) 1592 ])
1593 if all(re.search('[/_]ios[/_.]', f) for f in files): 1593 if all(re.search('[/_]ios[/_.]', f) for f in files):
1594 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator']) 1594 return GetDefaultTryConfigs(['ios_rel_device', 'ios_dbg_simulator'])
1595 1595
1596 builders = [ 1596 builders = [
1597 'android_chromium_gn_compile_rel', 1597 'android_chromium_gn_compile_rel',
1598 'android_clang_dbg', 1598 'android_clang_dbg',
1599 'android_dbg', 1599 'android_dbg_tests_recipe',
1600 'ios_dbg_simulator', 1600 'ios_dbg_simulator',
1601 'ios_rel_device', 1601 'ios_rel_device',
1602 'linux_chromium_chromeos_rel_swarming', 1602 'linux_chromium_chromeos_rel_swarming',
1603 'linux_chromium_clang_dbg', 1603 'linux_chromium_clang_dbg',
1604 'linux_chromium_gn_rel', 1604 'linux_chromium_gn_rel',
1605 'linux_chromium_rel_swarming', 1605 'linux_chromium_rel_swarming',
1606 'linux_gpu', 1606 'linux_gpu',
1607 'mac_chromium_compile_dbg', 1607 'mac_chromium_compile_dbg',
1608 'mac_chromium_rel_swarming', 1608 'mac_chromium_rel_swarming',
1609 'mac_gpu', 1609 'mac_gpu',
(...skipping 20 matching lines...) Expand all
1630 builders.extend(['cros_x86']) 1630 builders.extend(['cros_x86'])
1631 1631
1632 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1632 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1633 # unless they're .gyp(i) files as changes to those files can break the gyp 1633 # unless they're .gyp(i) files as changes to those files can break the gyp
1634 # step on that bot. 1634 # step on that bot.
1635 if (not all(re.search('^chrome', f) for f in files) or 1635 if (not all(re.search('^chrome', f) for f in files) or
1636 any(re.search('\.gypi?$', f) for f in files)): 1636 any(re.search('\.gypi?$', f) for f in files)):
1637 builders.extend(['android_aosp']) 1637 builders.extend(['android_aosp'])
1638 1638
1639 return GetDefaultTryConfigs(builders) 1639 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698