Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 496863004: Fix <extensionoptions> setAutoSize call (Closed)

Created:
6 years, 4 months ago by ericzeng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix <extensionoptions> setAutoSize call The browser plugin -internal-attach CL (https://codereview.chromium.org/444813002/) was committed just before the extension options autosizing animation CL (https://codereview.chromium.org/480243003/), so a call to guestViewInternal.setAutoSize() added in the second CL used a property that no longer existed (this.instanceId). Rename the variable so that the autosize call works again. BUG=386842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/renderer/resources/extensions/extension_options.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
ericzeng
PTAL, quick fix for a merge conflict
6 years, 4 months ago (2014-08-22 01:48:21 UTC) #1
Fady Samuel
lgtm
6 years, 4 months ago (2014-08-22 01:51:24 UTC) #2
not at google - send to devlin
lgtm
6 years, 4 months ago (2014-08-22 02:00:07 UTC) #3
ericzeng
The CQ bit was checked by ericzeng@chromium.org
6 years, 4 months ago (2014-08-22 02:00:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/496863004/1
6 years, 4 months ago (2014-08-22 02:02:32 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 03:05:17 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 03:58:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1232)
6 years, 4 months ago (2014-08-22 03:58:52 UTC) #8
ericzeng
The CQ bit was checked by ericzeng@chromium.org
6 years, 4 months ago (2014-08-22 04:03:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/496863004/1
6 years, 4 months ago (2014-08-22 04:04:51 UTC) #10
jam
On 2014/08/22 01:48:21, ericzeng wrote: > PTAL, quick fix for a merge conflict in the ...
6 years, 4 months ago (2014-08-22 04:11:14 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 05:00:28 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 05:03:48 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 05:03:49 UTC) #14
Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

Powered by Google App Engine
This is Rietveld 408576698