Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 496843002: Revert of Add ui_unittests to GN build. (Closed)

Created:
6 years, 4 months ago by rlarocque
Modified:
6 years, 4 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert of Add ui_unittests to GN build. (patchset #2 of https://codereview.chromium.org/496473003/) Reason for revert: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/2322 Original issue's description: > Add ui_unittests to GN build. > > Adds os_exchange_data_win_unittest.cc to Windows (it was incorrecly excluded before). Fixed a compilation error in that file. > > Remove special filtering out in GYP build of base/ime/chromeos/character_composer_unittest.cc and base/ime/input_method_chromeos_unittest.cc since the standard filtering patterns match both of these. > > R=sky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291154 TBR=sky@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291181

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -178 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D ui/BUILD.gn View 1 chunk +0 lines, -173 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ui_unittests.gyp View 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rlarocque
Created Revert of Add ui_unittests to GN build.
6 years, 4 months ago (2014-08-21 20:15:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/496843002/1
6 years, 4 months ago (2014-08-21 20:18:23 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 20:56:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (1) as 291181

Powered by Google App Engine
This is Rietveld 408576698