Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 496833002: remember to init fOrigPos in legacy constructor (Closed)

Created:
6 years, 4 months ago by reed1
Modified:
6 years, 4 months ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

remember to init fOrigPos in legacy constructor NOTREECHECKS=True Committed: https://skia.googlesource.com/skia/+/d5176a2fb6e86bba7b12df3d9f641228b30f3024

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
reed1
6 years, 4 months ago (2014-08-21 19:09:45 UTC) #1
caryclark
lgtm
6 years, 4 months ago (2014-08-21 19:20:12 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-21 19:24:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/496833002/20001
6 years, 4 months ago (2014-08-21 19:25:40 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 19:32:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (20001) as d5176a2fb6e86bba7b12df3d9f641228b30f3024

Powered by Google App Engine
This is Rietveld 408576698