Issue 496813002: export hard dependencies where needed in mojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 496813002: export hard dependencies where needed in mojo (Closed)

Created:
6 years, 4 months ago by jamesr

Modified:
6 years, 4 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

export hard dependencies where needed in mojo mojo/application_manager/application_loader.h #includes a generated header from mojo_network_bindings. This means any target that uses this header (and thus depends on application_manager) must declare a hard dependency on mojo_network_bindings so that the generated header exists before that target tries to compile. This exports the hard dep (via gyp's export_dependent_settings) and from other targets with similar needs. R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291273

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -8 lines)			Patch
M	mojo/mojo.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/mojo_base.gyp	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	mojo/mojo_services.gypi	View	1	6 chunks	+23 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/496813002/20001

6 years, 4 months ago (2014-08-21 20:18:19 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-22 00:39:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as 291273

Expand Messages | Collapse Messages