[SkTextBlob] Merge run font data at draw time.

[SkTextBlob] Merge run font data at draw time.

R=reed@google.com,bungeman@google.com

Committed: https://skia.googlesource.com/skia/+/37ecbaffd1f9f6841aa562aa31a824d109d52988

[reed1, 2014-08-21 21:42:15]

https://codereview.chromium.org/496773002/diff/1/include/core/SkTextBlob.h
File include/core/SkTextBlob.h (right):

https://codereview.chromium.org/496773002/diff/1/include/core/SkTextBlob.h#ne...
include/core/SkTextBlob.h:50: void applyFont(SkPaint&) const;
Nit:
- mutable arguments (expect ReadBuffer for some reason) are pointers, not refs
- applyToPaint(...)?

[f(malita), 2014-08-21 21:54:05]

https://codereview.chromium.org/496773002/diff/1/include/core/SkTextBlob.h
File include/core/SkTextBlob.h (right):

https://codereview.chromium.org/496773002/diff/1/include/core/SkTextBlob.h#ne...
include/core/SkTextBlob.h:50: void applyFont(SkPaint&) const;
On 2014/08/21 21:42:15, reed1 wrote:
> Nit:
> - mutable arguments (expect ReadBuffer for some reason) are pointers, not refs
> - applyToPaint(...)?

Done.

[reed1, 2014-08-22 15:36:41]

https://codereview.chromium.org/496773002/diff/20001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/496773002/diff/20001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:2234: it.applyFontToPaint(&runPaint);
As long as we always overwrite exactly the same stuff for each run, this is
fine. If not, we may need to re-seed with the original paint each time in the
loop.

https://codereview.chromium.org/496773002/diff/20001/src/core/SkTextBlob.cpp
File src/core/SkTextBlob.cpp (right):

https://codereview.chromium.org/496773002/diff/20001/src/core/SkTextBlob.cpp#...
src/core/SkTextBlob.cpp:94: paint->setFlags((paint->getFlags() & ~flagsMask) |
(font.getFlags() & flagsMask));
Does font.getFlags() return equivalent bit flags to paint? I think this process
will be more complicated (unfortunately).

[reed1, 2014-08-22 15:38:53]

lgtm

[f(malita), 2014-08-22 15:49:24]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-08-22 15:50:07]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/496773002/40001

[commit-bot: I haz the power, 2014-08-22 15:50:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 15:50:10]

Failed to apply patch for expectations/gm/ignored-tests.txt:
While running git apply --index -p1;
  error: patch failed: expectations/gm/ignored-tests.txt:32
  error: expectations/gm/ignored-tests.txt: patch does not apply

Patch:       expectations/gm/ignored-tests.txt
Index: expectations/gm/ignored-tests.txt
diff --git a/expectations/gm/ignored-tests.txt
b/expectations/gm/ignored-tests.txt
index
bf3a81ea75fc932c163bad876571cbacf3e2bc51..21c6c0f7825fa15bafd2526efa3a7c97b39c8879
100644
--- a/expectations/gm/ignored-tests.txt
+++ b/expectations/gm/ignored-tests.txt
@@ -32,3 +32,6 @@
 ## http://skbug.com/123456 : ignoring failures on gradtext GM test
 ## epoger will rebaseline by 25 Dec 2013
 #gradtext
+
+# To be rebaselined (fmalita)
+textblob

[f(malita), 2014-08-22 15:53:39]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-08-22 15:54:07]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/496773002/60001

[commit-bot: I haz the power, 2014-08-22 16:01:25]

Committed patchset #4 (60001) as 37ecbaffd1f9f6841aa562aa31a824d109d52988