Issue 496763002: Add apps to the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 496763002: Add apps to the GN build. (Closed)

Created:
6 years, 4 months ago by brettw

Modified:
6 years, 4 months ago

Reviewers:
miket_OOO

CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Add apps to the GN build. Remove duplicate reference of content_switches which causes link errors. Add dependency on theme_resources from apps (it includes the generated file). R=miket@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291150

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -3 lines)			Patch
M	BUILD.gn	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A	apps/BUILD.gn	View	1 chunk	+94 lines, -0 lines	0 comments	Download
M	apps/apps.gypi	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

Committed patchset #2 manually as 291150.