Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 496753002: Plug a memory leak in google_apis_unittests. (Closed)

Created:
6 years, 4 months ago by earthdok
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Plug a memory leak in google_apis_unittests. BUG=405985 R=rogerta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M google_apis/gaia/merge_session_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
earthdok
6 years, 4 months ago (2014-08-21 16:56:15 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm Nice catch. Thanks for fixing.
6 years, 4 months ago (2014-08-21 18:33:55 UTC) #2
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 4 months ago (2014-08-21 20:28:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/496753002/1
6 years, 4 months ago (2014-08-21 20:31:44 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 21:54:04 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 00:20:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (1) as 291264

Powered by Google App Engine
This is Rietveld 408576698