chrome/browser/android/tab_android.cc - Issue 496733005: Some favicon cleanup/upstreaming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_android.cc

Issue 496733005: Some favicon cleanup/upstreaming (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/tab_android.cc

diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc

index 0e40ea06c81f9cf24afb65a8a8f3d6a1f696f03b..75f3f5b05263ec90adce84a03562a0162add3e77 100644

--- a/chrome/browser/android/tab_android.cc

+++ b/chrome/browser/android/tab_android.cc

@@ -635,6 +635,11 @@ ScopedJavaLocalRef<jobject> TabAndroid::GetFavicon(JNIEnv* env, jobject obj) {

return bitmap;

}

+jboolean TabAndroid::IsFaviconValid(JNIEnv* env, jobject jobj) {

+ return web_contents() &&

+ FaviconTabHelper::FromWebContents(web_contents())->FaviconIsValid();

prerender::PrerenderManager* TabAndroid::GetPrerenderManager() const {

Profile* profile = GetProfile();

if (!profile)