Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 496713003: Guest session operates irrespective of IncognitoModePrefs (Closed)

Created:
6 years, 4 months ago by Mike Lerman
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Guest session operates irrespective of IncognitoModePrefs Sanity DCHECK for IncognitoModePrefs skipped for guest profile. BUG=395044 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291425

Patch Set 1 #

Patch Set 2 : Rewrite the DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/prefs/incognito_mode_prefs.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mike Lerman
Generous and Illustrious Reviewers, This insignificant (yet aspiring to be merged back to M38) CL ...
6 years, 4 months ago (2014-08-21 19:07:00 UTC) #1
Joao da Silva
lgtm, given that we have a different policy to disable guest mode altogether.
6 years, 4 months ago (2014-08-21 21:36:04 UTC) #2
Bernhard Bauer
lgtm
6 years, 4 months ago (2014-08-21 23:03:07 UTC) #3
Mike Lerman
Monica, it's a quick review for you, now!
6 years, 4 months ago (2014-08-22 00:29:42 UTC) #4
noms (inactive)
profiles lgtm
6 years, 4 months ago (2014-08-22 14:27:37 UTC) #5
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 4 months ago (2014-08-22 14:35:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/496713003/20001
6 years, 4 months ago (2014-08-22 14:36:45 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 15:30:42 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 16:25:35 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 291425

Powered by Google App Engine
This is Rietveld 408576698