Credential Manager: Stub out the browser-side IPC handlers.

components/password_manager/core/browser/password_manager_client.h

Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index 99f1282258cbf8a7f39a5c327fab276a2ea89664..5422f825699c561d385bb6f08864206107157e37 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -14,6 +14,7 @@ class PrefService;
 
 namespace password_manager {
 
+struct CredentialInfo;
 class PasswordFormManager;
 class PasswordManagerDriver;
 class PasswordStore;
@@ -114,6 +115,24 @@ class PasswordManagerClient {
   virtual PasswordStore::AuthorizationPromptPolicy GetAuthorizationPromptPolicy(
       const autofill::PasswordForm& form);
 
+  // Called in response to an IPC from the renderer, triggered by a page's call
+  // to 'navigator.credentials.notifyFailedSignIn'.
+  virtual void OnNotifyFailedSignIn(int request_id, const CredentialInfo&) = 0;

[vabr (Chromium), 2014/08/22 14:04:32]

optional: I would suggest stubbing these right here in the interface.
Everything pure virtual added here needs an immediate action (implementation) on
the iOS part of the code. That is useful if the implementation actually needs to
be done on iOS, which IIUC is not the case here right now.

You might want to confirm with blundell@, except he comes back from holiday at
the moment you leave for it. :)

+
+  // Called in response to an IPC from the renderer, triggered by a page's call
+  // to 'navigator.credentials.notifySignedIn'.
+  virtual void OnNotifySignedIn(int request_id, const CredentialInfo&) = 0;
+
+  // Called in response to an IPC from the renderer, triggered by a page's call
+  // to 'navigator.credentials.notifySignedOut'.
+  virtual void OnNotifySignedOut(int request_id) = 0;
+
+  // Called in response to an IPC from the renderer, triggered by a page's call
+  // to 'navigator.credentials.request'.
+  virtual void OnRequestCredential(int request_id,
+                                   bool zero_click_only,
+                                   std::vector<GURL> federations) = 0;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(PasswordManagerClient);
 };