Credential Manager: Stub out the browser-side IPC handlers.

chrome/browser/password_manager/chrome_password_manager_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
+#include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/password_manager/password_manager_util.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/password_manager/save_password_infobar_delegate.h"
 #include "chrome/browser/password_manager/sync_metrics.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/ui/autofill/password_generation_popup_controller_impl.h"
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/url_constants.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/core/browser/password_generator.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/content/browser/password_manager_internals_service_factory.h"
+#include "components/password_manager/content/common/credential_manager_messages.h"
+#include "components/password_manager/content/common/credential_manager_types.h"
 #include "components/password_manager/core/browser/log_receiver.h"
 #include "components/password_manager/core/browser/password_form_manager.h"
 #include "components/password_manager/core/browser/password_manager.h"
 #include "components/password_manager/core/browser/password_manager_internals_service.h"
 #include "components/password_manager/core/browser/password_manager_metrics_util.h"
 #include "components/password_manager/core/common/password_manager_switches.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "google_apis/gaia/gaia_urls.h"
@@ skipping 232 matching lines @@
   if (service)
     service->ProcessLog(text);
 }
 
 bool ChromePasswordManagerClient::IsLoggingActive() const {
   // WebUI tabs do not need to log password saving progress. In particular, the
   // internals page itself should not send any logs.
   return can_use_log_router_ && !web_contents()->GetWebUI();
 }
 
+void ChromePasswordManagerClient::OnNotifyFailedSignIn(
+    int request_id,
+    const password_manager::CredentialInfo&) {
+  // TODO(mkwst): This is a stub.
+  web_contents()->GetRenderViewHost()->Send(
+      new CredentialManagerMsg_AcknowledgeFailedSignIn(
+          web_contents()->GetRenderViewHost()->GetRoutingID(), request_id));
+}
+
+void ChromePasswordManagerClient::OnNotifySignedIn(
+    int request_id,
+    const password_manager::CredentialInfo&) {
+  // TODO(mkwst): This is a stub.
+  web_contents()->GetRenderViewHost()->Send(
+      new CredentialManagerMsg_AcknowledgeSignedIn(
+          web_contents()->GetRenderViewHost()->GetRoutingID(), request_id));
+}
+
+void ChromePasswordManagerClient::OnNotifySignedOut(int request_id) {
+  // TODO(mkwst): This is a stub.
+  web_contents()->GetRenderViewHost()->Send(
+      new CredentialManagerMsg_AcknowledgeSignedOut(
+          web_contents()->GetRenderViewHost()->GetRoutingID(), request_id));
+}
+
+void ChromePasswordManagerClient::OnRequestCredential(
+    int request_id,
+    bool zero_click_only,
+    std::vector<GURL> federations) {

[vabr (Chromium), 2014/08/22 14:04:32]

optional: My gut feeling would be that making this a const ref would spare
copying. But I did not check the IPC macros thoroughly for that.

+  // TODO(mkwst): This is a stub.
+  password_manager::CredentialInfo info(base::ASCIIToUTF16("id"),
+                                        base::ASCIIToUTF16("name"),
+                                        GURL("https://example.com/image.png"));
+  web_contents()->GetRenderViewHost()->Send(
+      new CredentialManagerMsg_SendCredential(
+          web_contents()->GetRenderViewHost()->GetRoutingID(),
+          request_id,
+          info));
+}
+
 // static
 password_manager::PasswordGenerationManager*
 ChromePasswordManagerClient::GetGenerationManagerFromWebContents(
     content::WebContents* contents) {
   ChromePasswordManagerClient* client =
       ChromePasswordManagerClient::FromWebContents(contents);
   if (!client)
     return NULL;
   return client->GetDriver()->GetPasswordGenerationManager();
 }
@@ skipping 11 matching lines @@
 
 void ChromePasswordManagerClient::SetTestObserver(
     autofill::PasswordGenerationPopupObserver* observer) {
   observer_ = observer;
 }
 
 bool ChromePasswordManagerClient::OnMessageReceived(
     const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(ChromePasswordManagerClient, message)
+    // Autofill messages:
     IPC_MESSAGE_HANDLER(AutofillHostMsg_ShowPasswordGenerationPopup,
                         ShowPasswordGenerationPopup)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_ShowPasswordEditingPopup,
                         ShowPasswordEditingPopup)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_HidePasswordGenerationPopup,
                         HidePasswordGenerationPopup)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordAutofillAgentConstructed,
                         NotifyRendererOfLoggingAvailability)
+
+    // Credential Manager messages:
+    IPC_MESSAGE_HANDLER(CredentialManagerHostMsg_NotifyFailedSignIn,
+                        OnNotifyFailedSignIn);
+    IPC_MESSAGE_HANDLER(CredentialManagerHostMsg_NotifySignedIn,
+                        OnNotifySignedIn);
+    IPC_MESSAGE_HANDLER(CredentialManagerHostMsg_NotifySignedOut,
+                        OnNotifySignedOut);
+    IPC_MESSAGE_HANDLER(CredentialManagerHostMsg_RequestCredential,
+                        OnRequestCredential);
+
+    // Default:
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 gfx::RectF ChromePasswordManagerClient::GetBoundsInScreenSpace(
     const gfx::RectF& bounds) {
   gfx::Rect client_area = web_contents()->GetContainerBounds();
   return bounds + client_area.OffsetFromOrigin();
 }
@@ skipping 132 matching lines @@
 
   if (group_name == "DisallowSyncCredentialsForReauth") {
     autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS_FOR_REAUTH;
   } else if (group_name == "DisallowSyncCredentials") {
       autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS;
   } else {
     // Allow by default.
     autofill_sync_state_ = ALLOW_SYNC_CREDENTIALS;
   }
 }