Updating buffered duration of local resource in android

Updating buffered duration of local resource in android

OnBufferingUpdate does not work for local resources. Because of this
the buffered range does not get updated. This patch updates the bufferd
range atleast untill the video has played so that media controls can be
painted properly.

TBR=abarth@chromium.org
BUG=405474
Committed: https://crrev.com/ee85a1188ee2454e62dc24c58477df39970a990b
Cr-Commit-Position: refs/heads/master@{#292837}

[amogh.bihani, 2014-08-21 09:02:12]

PTAL.

Since the buffering update does not work for local resources in android, I have
made use of the timer used in media player bridge to call ontimeupdate.

[amogh.bihani, 2014-08-21 09:06:32]

https://codereview.chromium.org/496683002/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/496683002/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.cc:220: is_local_resource_
= url_.SchemeIsFile() || url_.SchemeIs("blob");
Ah! sorry I'll make it to SchemeIsBlob in next PS.

[qinmin, 2014-08-21 16:43:07]

https://codereview.chromium.org/496683002/diff/1/content/renderer/media/andro...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/496683002/diff/1/content/renderer/media/andro...
content/renderer/media/android/webmediaplayer_android.cc:220: is_local_resource_
= url_.SchemeIsFile() || url_.SchemeIs("blob");
I think you should also check whether the address is a local loopback
address(127.0.0.1, eg)
On 2014/08/21 09:06:31, amogh.bihani wrote:
> Ah! sorry I'll make it to SchemeIsBlob in next PS.

[amogh.bihani, 2014-08-22 09:02:45]

Thanks for the review :)

https://codereview.chromium.org/496683002/diff/20001/content/renderer/media/a...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/496683002/diff/20001/content/renderer/media/a...
content/renderer/media/android/webmediaplayer_android.cc:856: if
(is_local_resource_ && current_time_ <= duration())
I have used a bool instead of calling IsLocalResource() here because this is a
very frequent call and it is redundant to compute it every time.

[amogh.bihani, 2014-08-26 03:32:52]

On 2014/08/22 09:02:45, amogh.bihani wrote:
> Thanks for the review :)
> 
>
https://codereview.chromium.org/496683002/diff/20001/content/renderer/media/a...
> File content/renderer/media/android/webmediaplayer_android.cc (right):
> 
>
https://codereview.chromium.org/496683002/diff/20001/content/renderer/media/a...
> content/renderer/media/android/webmediaplayer_android.cc:856: if
> (is_local_resource_ && current_time_ <= duration())
> I have used a bool instead of calling IsLocalResource() here because this is a
> very frequent call and it is redundant to compute it every time.

Ping!

[qinmin, 2014-08-26 03:44:17]

https://codereview.chromium.org/496683002/diff/20001/content/renderer/media/a...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/496683002/diff/20001/content/renderer/media/a...
content/renderer/media/android/webmediaplayer_android.cc:286: if
(url_.spec().find("//127.0.0.1/") != std::string::npos ||  // port 80
use:
 std::string host = url_.host();
 if (!host.compare("localhost") || !host.compare("127.0.0.1") ||
!host.compare("[::1]))
  return true;

[amogh.bihani, 2014-08-26 05:31:14]

Thanks :)

https://codereview.chromium.org/496683002/diff/20001/content/renderer/media/a...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/496683002/diff/20001/content/renderer/media/a...
content/renderer/media/android/webmediaplayer_android.cc:286: if
(url_.spec().find("//127.0.0.1/") != std::string::npos ||  // port 80
On 2014/08/26 03:44:17, qinmin wrote:
> use:
>  std::string host = url_.host();
>  if (!host.compare("localhost") || !host.compare("127.0.0.1") ||
> !host.compare("[::1]))
>   return true;

Done.

[qinmin, 2014-08-26 06:24:55]

lgtm

[amogh.bihani, 2014-08-26 07:00:00]

amogh.bihani@samsung.com changed reviewers:
+ abarth@chromium.org

[amogh.bihani, 2014-08-26 07:00:48]

Thanks for the review :)

+abarth for url/

[amogh.bihani, 2014-08-27 13:24:16]

On 2014/08/26 07:00:48, amogh.bihani wrote:
> Thanks for the review :)
> 
> +abarth for url/

abarth@ PTAL.

[amogh.bihani, 2014-09-01 05:06:36]

On 2014/08/27 13:24:16, amogh.bihani wrote:
> On 2014/08/26 07:00:48, amogh.bihani wrote:
> > Thanks for the review :)
> > 
> > +abarth for url/
> 
> abarth@ PTAL.

abarth@ Please have a look whenever you get time and let me know if there is
anything I need to add to this.
Using TBR for now.

[amogh.bihani, 2014-09-01 05:07:09]

The CQ bit was checked by amogh.bihani@samsung.com

[commit-bot: I haz the power, 2014-09-01 05:09:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/496683002/40001

[commit-bot: I haz the power, 2014-09-01 06:07:54]

Committed patchset #3 (id:40001) as 4aa3cec8ae0c8dd5264546ccd8c5e4727ca2b110

[abarth-chromium, 2014-09-02 19:31:21]

//url LGTM

[commit-bot: I haz the power, 2014-09-10 03:15:42]

Patchset 3 (id:??) landed as
https://crrev.com/ee85a1188ee2454e62dc24c58477df39970a990b
Cr-Commit-Position: refs/heads/master@{#292837}