Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: src/apinatives.js

Issue 496663002: Fix symbol-named function template properties in the API (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 "use strict"; 5 "use strict";
6 6
7 // This file contains infrastructure used by the API. See 7 // This file contains infrastructure used by the API. See
8 // v8natives.js for an explanation of these files are processed and 8 // v8natives.js for an explanation of these files are processed and
9 // loaded. 9 // loaded.
10 10
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 65
66 var parent = %GetTemplateField(data, kApiParentTemplateOffset); 66 var parent = %GetTemplateField(data, kApiParentTemplateOffset);
67 // Note: Do not directly use a function template as a condition, our 67 // Note: Do not directly use a function template as a condition, our
68 // internal ToBoolean doesn't handle that! 68 // internal ToBoolean doesn't handle that!
69 if (typeof parent !== 'undefined') { 69 if (typeof parent !== 'undefined') {
70 var parent_fun = Instantiate(parent); 70 var parent_fun = Instantiate(parent);
71 %InternalSetPrototype(prototype, parent_fun.prototype); 71 %InternalSetPrototype(prototype, parent_fun.prototype);
72 } 72 }
73 } 73 }
74 var fun = %CreateApiFunction(data, prototype); 74 var fun = %CreateApiFunction(data, prototype);
75 if (name) %FunctionSetName(fun, name); 75 if (IS_STRING(name)) %FunctionSetName(fun, name);
76 var doNotCache = flags & (1 << kDoNotCacheBit); 76 var doNotCache = flags & (1 << kDoNotCacheBit);
77 if (!doNotCache) cache[serialNumber] = fun; 77 if (!doNotCache) cache[serialNumber] = fun;
78 ConfigureTemplateInstance(fun, data); 78 ConfigureTemplateInstance(fun, data);
79 if (doNotCache) return fun; 79 if (doNotCache) return fun;
80 } catch (e) { 80 } catch (e) {
81 cache[serialNumber] = kUninitialized; 81 cache[serialNumber] = kUninitialized;
82 throw e; 82 throw e;
83 } 83 }
84 } 84 }
85 return cache[serialNumber]; 85 return cache[serialNumber];
(...skipping 24 matching lines...) Expand all
110 %DefineApiAccessorProperty(obj, name, getter, setter, attribute); 110 %DefineApiAccessorProperty(obj, name, getter, setter, attribute);
111 } else { 111 } else {
112 throw "Bad properties array"; 112 throw "Bad properties array";
113 } 113 }
114 i += length + 1; 114 i += length + 1;
115 } 115 }
116 } finally { 116 } finally {
117 if (requires_access_checks) %EnableAccessChecks(obj); 117 if (requires_access_checks) %EnableAccessChecks(obj);
118 } 118 }
119 } 119 }
OLDNEW
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698