Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 496663002: Fix symbol-named function template properties in the API (Closed)

Created:
6 years, 4 months ago by wingo
Modified:
6 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix symbol-named function template properties in the API Thanks to Yutaka Hirano <yhirano@chromium.org>; for finding the bug and providing the test case. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/apinatives.js View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wingo
The path taken to get to this bug is twisted -- api.cc's ObjectTemplate::NewInstance calls execution.cc ...
6 years, 4 months ago (2014-08-21 08:36:57 UTC) #1
rossberg
LGTM
6 years, 4 months ago (2014-08-21 11:22:28 UTC) #2
wingo
Committed patchset #1 manually as 23269 (presubmit successful).
6 years, 4 months ago (2014-08-21 11:55:55 UTC) #3
yhirano
6 years, 4 months ago (2014-08-21 12:10:42 UTC) #4
Message was sent while issue was closed.
Thank you for the fix!

Powered by Google App Engine
This is Rietveld 408576698