Issue 496603002: Revert back to SkPictureData pictures. Huge perf regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 496603002: Revert back to SkPictureData pictures. Huge perf regression. (Closed)

Created:
6 years, 4 months ago by mtklein_C

Modified:
6 years, 4 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert back to SkPictureData pictures. Huge perf regression. http://skiaperf.com/#108 BUG=skia: Committed: https://skia.googlesource.com/skia/+/4082d290eea2f70caa82120ff3bc4fbdccbf206c

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	src/core/SkPicture.cpp	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/496603002/1

6 years, 4 months ago (2014-08-20 23:11:35 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (1) as 4082d290eea2f70caa82120ff3bc4fbdccbf206c

6 years, 4 months ago (2014-08-20 23:18:30 UTC) #5

mtklein

6 years, 4 months ago (2014-08-22 00:10:02 UTC) #6

Message was sent while issue was closed.

A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/496173002/ by mtklein@google.com.

The reason for reverting is: Try again now that we have --bbh on nanobench and
it's looking decent..

Expand Messages | Collapse Messages