Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: sdk/lib/_internal/pub/lib/src/solver/version_solver.dart

Issue 496583002: Fix tests for pub global activate. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update more tests. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/solver/version_solver.dart
diff --git a/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart b/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart
index ec276ea22d0911d0c8185405897348840e056534..4b8086179addcb79568474c129419e09919600dc 100644
--- a/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart
+++ b/sdk/lib/_internal/pub/lib/src/solver/version_solver.dart
@@ -276,13 +276,16 @@ class Dependency {
/// The version of the depender that has this dependency.
///
- /// This will be `null` when [depender] is the magic "pub itself" dependency.
- final Version dependerVersion;
+ /// This will be `null` when [depender] is a magic dependency (e.g. "pub
+ /// itself" or "pub global activate").
+ Version get dependerVersion =>
+ depender.contains(" ") ? null : _dependerVersion;
Bob Nystrom 2014/08/20 23:29:28 How about just returning the actual version here.
nweiz 2014/08/20 23:38:05 Done.
+ final Version _dependerVersion;
/// The package being depended on.
final PackageDep dep;
- Dependency(this.depender, this.dependerVersion, this.dep);
+ Dependency(this.depender, this._dependerVersion, this.dep);
String toString() => '$depender $dependerVersion -> $dep';
}

Powered by Google App Engine
This is Rietveld 408576698