Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 496503002: Delete obsolete GPU rasterization content whitelist code (Closed)

Created:
6 years, 4 months ago by ajuma
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, piman+watch_chromium.org, ernstm
Project:
chromium
Visibility:
Public.

Description

Delete obsolete GPU rasterization content whitelist code This deletes code that was previously used for deciding if the expanded content whitelist for GPU rasterization should be used. Blink now uses the expanded whitelist by default (that is, WebSettings::setUseExpandedHeuristicsForGpuRasterization is now a no-op), so this code is no longer needed. BUG=404866 Committed: https://crrev.com/4739a2c57d5f288aadcd91b7236de25b7dfd8825 Cr-Commit-Position: refs/heads/master@{#291744}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -40 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/config/gpu_blacklist.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/config/gpu_blacklist_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/config/gpu_feature_type.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/config/software_rendering_list_json.cc View 2 chunks +1 line, -20 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ajuma
creis: please review content/ zmo: please review gpu/
6 years, 4 months ago (2014-08-22 16:03:51 UTC) #1
Charlie Reis
content/ LGTM
6 years, 4 months ago (2014-08-22 16:17:44 UTC) #2
Charlie Reis
[+nasko] Looks like you may need an IPC owner's review for content/public/common/common_param_traits_macros.h, as well.
6 years, 4 months ago (2014-08-22 16:18:56 UTC) #3
nasko
IPC LGTM
6 years, 4 months ago (2014-08-22 16:31:25 UTC) #4
Zhenyao Mo
LGTM
6 years, 4 months ago (2014-08-25 18:16:41 UTC) #5
ajuma
The CQ bit was checked by ajuma@chromium.org
6 years, 4 months ago (2014-08-25 18:52:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/496503002/20001
6 years, 4 months ago (2014-08-25 18:52:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (20001) as 67f5cf238b439f71d69661c8fad766ae6c0f712a
6 years, 4 months ago (2014-08-25 19:46:48 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:36:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4739a2c57d5f288aadcd91b7236de25b7dfd8825
Cr-Commit-Position: refs/heads/master@{#291744}

Powered by Google App Engine
This is Rietveld 408576698