Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 496473003: Add ui_unittests to GN build. (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
sky, dcheng
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add ui_unittests to GN build. Adds os_exchange_data_win_unittest.cc to Windows (it was incorrecly excluded before). Fixed a compilation error in that file. Remove special filtering out in GYP build of base/ime/chromeos/character_composer_unittest.cc and base/ime/input_method_chromeos_unittest.cc since the standard filtering patterns match both of these. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291154

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -12 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A ui/BUILD.gn View 1 chunk +173 lines, -0 lines 0 comments Download
D ui/base/dragdrop/os_exchange_data_win_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ui_unittests.gyp View 1 4 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
brettw
6 years, 4 months ago (2014-08-20 22:08:44 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-20 22:28:19 UTC) #2
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 4 months ago (2014-08-20 22:29:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/496473003/1
6 years, 4 months ago (2014-08-20 22:30:46 UTC) #4
dcheng
On 2014/08/20 22:29:17, brettw wrote: > The CQ bit was checked by mailto:brettw@chromium.org Not lgtm ...
6 years, 4 months ago (2014-08-20 22:31:04 UTC) #5
dcheng
The CQ bit was unchecked by dcheng@chromium.org
6 years, 4 months ago (2014-08-20 22:31:15 UTC) #6
brettw
I put back the exchange data file and fixed the syntax error it in.
6 years, 4 months ago (2014-08-21 16:43:42 UTC) #7
dcheng
On 2014/08/21 at 16:43:42, brettw wrote: > I put back the exchange data file and ...
6 years, 4 months ago (2014-08-21 18:34:49 UTC) #8
brettw
Committed patchset #2 manually as 291154 (presubmit successful).
6 years, 4 months ago (2014-08-21 19:20:14 UTC) #9
rlarocque
6 years, 4 months ago (2014-08-21 20:15:22 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2) has been created in
https://codereview.chromium.org/496843002/ by rlarocque@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

Powered by Google App Engine
This is Rietveld 408576698