Issue 496443003: Add ARMv6 support for the out-of-line constant pool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 496443003: Add ARMv6 support for the out-of-line constant pool. (Closed)

Created:
6 years, 4 months ago by rmcilroy

Modified:
6 years, 4 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Add ARMv6 support for the out-of-line constant pool. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23278

Patch Set 2 : kImmed8 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+276 lines, -69 lines)			Patch
M	src/arm/assembler-arm.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/arm/assembler-arm.cc	View	1	8 chunks	+99 lines, -27 lines	0 comments	Download
M	src/arm/assembler-arm-inl.h	View		8 chunks	+118 lines, -29 lines	0 comments	Download
M	src/arm/constants-arm.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	1	5 chunks	+53 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

lgtm https://codereview.chromium.org/496443003/diff/1/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://codereview.chromium.org/496443003/diff/1/src/arm/assembler-arm.cc#newcode3810 src/arm/assembler-arm.cc:3810: Assembler::PatchShiftImm(instr, (offset & 0xff))); s/0xff/kImm8Mask here and below.

6 years, 4 months ago (2014-08-21 12:15:47 UTC) #2

rmcilroy

Thanks Ulan. https://codereview.chromium.org/496443003/diff/1/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://codereview.chromium.org/496443003/diff/1/src/arm/assembler-arm.cc#newcode3810 src/arm/assembler-arm.cc:3810: Assembler::PatchShiftImm(instr, (offset & 0xff))); On 2014/08/21 12:15:47, ...

6 years, 4 months ago (2014-08-21 13:02:04 UTC) #3

rmcilroy

6 years, 4 months ago (2014-08-21 13:26:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 23278 (presubmit successful).

Expand Messages | Collapse Messages

Issue 496443003: Add ARMv6 support for the out-of-line constant pool. (Closed)

Description

Patch Set 1 #

Patch Set 2 : kImmed8 #

Messages