Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/extensions/location_bar_controller.h

Issue 496403003: Remove NOTIFICATION_EXTENSION_PAGE_ACTIONS_UPDATED (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/location_bar_controller.h
diff --git a/chrome/browser/extensions/location_bar_controller.h b/chrome/browser/extensions/location_bar_controller.h
index 36c9dd4872338fefe2f1439a37bd0c1443b8fa49..afed4107697b00c11db4dc852ddaa5c261243741 100644
--- a/chrome/browser/extensions/location_bar_controller.h
+++ b/chrome/browser/extensions/location_bar_controller.h
@@ -48,8 +48,8 @@ class LocationBarController : public content::WebContentsObserver,
// A notification that the given |extension| has been unloaded, and any
// actions associated with it should be removed.
- // The location bar controller will update itself after this if needed, so
- // Providers should not call NotifyChange().
+ // The LocationBarController will handle notifying of page action changes,
+ // if any.
virtual void OnExtensionUnloaded(const Extension* extension) {}
};
@@ -63,9 +63,6 @@ class LocationBarController : public content::WebContentsObserver,
// action which should be taken in response (if any).
ExtensionAction::ShowAction OnClicked(const ExtensionAction* action);
- // Notifies the window that the actions have changed.
- static void NotifyChange(content::WebContents* web_contents);
-
ActiveScriptController* active_script_controller() {
return active_script_controller_.get();
}

Powered by Google App Engine
This is Rietveld 408576698