Chromium Code Reviews

Issue 496393002: MIPS: Move IC code into a subdir and move ic-compilation related code from stub-cache into ic-compi… (Closed)

Created:
6 years, 4 months ago by balazs.kilvady
Modified:
6 years, 4 months ago
Reviewers:
dusmil.imgtec, danno, Toon Verwaest, paul.l..., gergely.kis.imgtec, akos.palfi.imgtec
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Move IC code into a subdir and move ic-compilation related code from stub-cache into ic-compiler. Port r23306 (b95f295) BUG= R=paul.lind@imgtec.com, verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23340

Patch Set 1 #

Patch Set 2 : Fix formatting #

Unified diffs Side-by-side diffs Stats (+406 lines, -5860 lines)
M BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments
A + src/ic/mips/ic-compiler-mips.cc View 28 chunks +55 lines, -258 lines 0 comments
A + src/ic/mips/ic-mips.cc View 39 chunks +103 lines, -184 lines 0 comments
A + src/ic/mips/stub-cache-mips.cc View 6 chunks +29 lines, -35 lines 0 comments
A + src/ic/mips64/ic-compiler-mips64.cc View 29 chunks +56 lines, -263 lines 0 comments
A + src/ic/mips64/ic-mips64.cc View 41 chunks +104 lines, -185 lines 0 comments
A + src/ic/mips64/stub-cache-mips64.cc View 8 chunks +36 lines, -41 lines 0 comments
M src/mips/builtins-mips.cc View 1 chunk +1 line, -1 line 0 comments
M src/mips/code-stubs-mips.h View 1 chunk +1 line, -1 line 0 comments
M src/mips/code-stubs-mips.cc View 1 chunk +4 lines, -1 line 0 comments
M src/mips/codegen-mips.h View 1 chunk +1 line, -1 line 0 comments
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -1 line 0 comments
D src/mips/ic-mips.cc View 1 chunk +0 lines, -1259 lines 0 comments
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments
D src/mips/stub-cache-mips.cc View 1 chunk +0 lines, -1173 lines 0 comments
M src/mips64/builtins-mips64.cc View 1 chunk +0 lines, -1 line 0 comments
M src/mips64/code-stubs-mips64.h View 1 chunk +1 line, -1 line 0 comments
M src/mips64/code-stubs-mips64.cc View 1 chunk +4 lines, -1 line 0 comments
M src/mips64/codegen-mips64.h View 1 chunk +1 line, -1 line 0 comments
M src/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -1 line 0 comments
D src/mips64/ic-mips64.cc View 1 chunk +0 lines, -1266 lines 0 comments
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +0 lines, -1 line 0 comments
D src/mips64/stub-cache-mips64.cc View 1 chunk +0 lines, -1178 lines 0 comments
M tools/gyp/v8.gyp View 4 chunks +6 lines, -4 lines 0 comments

Messages

Total messages: 7 (0 generated)
balazs.kilvady
6 years, 4 months ago (2014-08-22 17:30:01 UTC) #1
paul.l...
LGTM, but we'll need a v8 review to PTAL also. (Note that some of the ...
6 years, 4 months ago (2014-08-22 18:04:00 UTC) #2
Toon Verwaest
Note that the formatting changes were just done by "git cl format".
6 years, 4 months ago (2014-08-22 18:06:09 UTC) #3
balazs.kilvady
Formatting update uploaded.
6 years, 4 months ago (2014-08-22 18:26:18 UTC) #4
paul.l...
Toon, could you please take another look?
6 years, 4 months ago (2014-08-22 18:27:54 UTC) #5
Toon Verwaest
lgtm
6 years, 4 months ago (2014-08-25 08:34:43 UTC) #6
balazs.kilvady
6 years, 4 months ago (2014-08-25 09:09:47 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 manually as r23340.

Powered by Google App Engine