Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 496363004: Makes analyzer output names of all executable target types (Closed)

Created:
6 years, 4 months ago by sky
Modified:
6 years, 4 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Makes analyzer output names of all executable target types This makes it easier to detect if something is going to be built without knowing all the names of dependent targets. For example, in chrome it's typical to have a _run target, eg browser_tests_run. Without this the chrome side would have to look for all the _foo targets. BUG=109173 TEST=none R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M pylib/gyp/generator/analyzer.py View 4 chunks +11 lines, -3 lines 0 comments Download
M test/analyzer/gyptest-analyzer.py View 2 chunks +3 lines, -3 lines 0 comments Download
M test/analyzer/test3.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
6 years, 4 months ago (2014-08-22 21:49:30 UTC) #1
scottmg
lgtm
6 years, 4 months ago (2014-08-22 21:54:17 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 4 months ago (2014-08-22 22:10:11 UTC) #3
sky
I wish the commit box worked.
6 years, 4 months ago (2014-08-22 22:10:53 UTC) #4
sky
6 years, 4 months ago (2014-08-22 22:11:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r1969 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698