Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 496363003: DevTools: Make Frontend treat remote service workers as workers (Closed)

Created:
6 years, 4 months ago by vkuzkokov
Modified:
6 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: Make Frontend treat remote service workers as workers When applied together with CL 459403002 it makes DevTools frontend for service worker to look like the one for local worker (e.g. only the tabs that are relevant to workers are shown). BUG=389454 Committed: https://crrev.com/a52eb8ad95965b5df889e7d6f076a8d4bfcccaea Cr-Commit-Position: refs/heads/master@{#291706}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Used constants. Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -15 lines) Patch
M chrome/browser/devtools/device/devtools_android_bridge.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_target_impl.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_target_impl.cc View 1 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/devtools/devtools_window.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vkuzkokov
When applied together with CL 459403002 it makes DevTools frontend for service worker to look ...
6 years, 4 months ago (2014-08-22 16:20:55 UTC) #1
dgozman
Please add bug number. lgtm https://codereview.chromium.org/496363003/diff/1/chrome/browser/devtools/device/devtools_android_bridge.cc File chrome/browser/devtools/device/devtools_android_bridge.cc (right): https://codereview.chromium.org/496363003/diff/1/chrome/browser/devtools/device/devtools_android_bridge.cc#newcode488 chrome/browser/devtools/device/devtools_android_bridge.cc:488: bool isWorker = remote_type_ ...
6 years, 4 months ago (2014-08-22 16:33:03 UTC) #2
vkuzkokov
https://codereview.chromium.org/496363003/diff/1/chrome/browser/devtools/device/devtools_android_bridge.cc File chrome/browser/devtools/device/devtools_android_bridge.cc (right): https://codereview.chromium.org/496363003/diff/1/chrome/browser/devtools/device/devtools_android_bridge.cc#newcode488 chrome/browser/devtools/device/devtools_android_bridge.cc:488: bool isWorker = remote_type_ == "worker" || remote_type_ == ...
6 years, 4 months ago (2014-08-25 15:11:38 UTC) #3
vkuzkokov
The CQ bit was checked by vkuzkokov@chromium.org
6 years, 4 months ago (2014-08-25 15:11:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vkuzkokov@chromium.org/496363003/20001
6 years, 4 months ago (2014-08-25 15:12:16 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-25 17:06:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (20001) as a59fa05d4a2d159520a1b6ead741fc834bf7e2d0
6 years, 4 months ago (2014-08-25 17:40:07 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:35:23 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a52eb8ad95965b5df889e7d6f076a8d4bfcccaea
Cr-Commit-Position: refs/heads/master@{#291706}

Powered by Google App Engine
This is Rietveld 408576698