Add --optimize_for_size to tests flag matrix.

tools/run-tests.py

 #!/usr/bin/env python
 #
 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 36 matching lines @@
 
 
 ARCH_GUESS = utils.DefaultArch()
 DEFAULT_TESTS = ["mjsunit", "cctest", "message", "preparser"]
 TIMEOUT_DEFAULT = 60
 TIMEOUT_SCALEFACTOR = {"debug"   : 4,
                        "release" : 1 }
 
 # Use this to run several variants of the tests.
 VARIANT_FLAGS = [[],
+                 ["--optimize-for-size"],

[Sven Panne, 2013/10/29 12:43:31]

I am not sure if this is the right way to proceed, because it will blow up our
test times significantly. Of course it would be a nice-to-have for each flag,
but we can't afford this due to combinatorial explosion.

Perhaps we can have a runner on our waterfall with this flag enabled instead?

[rmcilroy, 2013/10/29 14:02:55]

I realize this will increase test time by about 25% - that's why I didn't
introduce it in the original CL - but I think it's important to test with this
flag enabled since it significantly changes generated prologue code (and will
change other generated code as more optimizations are added), and the
run-tests.py tests found some issues which weren't apparent when running the JS
benchmarks.

Having a runner (for each arch) with this flag enabled would be OK, but are
there extra runners available on which we can enable this flag (from what I can
see, there is only a single ARM runner on the V8 waterfall, and I think we want
to test both with and without the flag).  Thoughts?

                  ["--stress-opt", "--always-opt"],
                  ["--nocrankshaft"]]
 MODE_FLAGS = {
     "debug"   : ["--nobreak-on-abort", "--nodead-code-elimination",
                  "--nofold-constants", "--enable-slow-asserts",
                  "--debug-code", "--verify-heap"],
     "release" : ["--nobreak-on-abort", "--nodead-code-elimination",
                  "--nofold-constants"]}
 
 SUPPORTED_ARCHS = ["android_arm",
@@ skipping 324 matching lines @@
   except KeyboardInterrupt:
     return 1
 
   if options.time:
     verbose.PrintTestDurations(suites, overall_duration)
   return exit_code
 
 
 if __name__ == "__main__":
   sys.exit(Main())