Issue 496323003: Add missing pref_registry dependency from dom_distiller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 496323003: Add missing pref_registry dependency from dom_distiller (Closed)

Created:
6 years, 4 months ago by scottmg

Modified:
6 years, 4 months ago

Reviewers:
nyquist

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add missing pref_registry dependency from dom_distiller Otherwise, Windows Release incremental links fail with: dom_distiller_core.distilled_page_prefs.obj : error LNK2019: unresolved external symbol "public: void __thiscall user_prefs::PrefRegistrySyncable::RegisterIntegerPref(char const *,int,enum user_prefs::PrefRegistrySyncable::PrefSyncStatus)" (?RegisterIntegerPref@PrefRegistrySyncable@user_prefs@@QAEXPBDHW4PrefSyncStatus@12@@Z) referenced in function "public: static void __cdecl dom_distiller::DistilledPagePrefs::RegisterProfilePrefs(class user_prefs::PrefRegistrySyncable *)" (?RegisterProfilePrefs@DistilledPagePrefs@dom_distiller@@SAXPAVPrefRegistrySyncable@user_prefs@@@Z) R=nyquist@chromium.org BUG=404809 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291513