Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 496313003: Adding DumpAccessibilityTree Tests (Closed)

Created:
6 years, 4 months ago by shreeramk
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding DumpAccessibilityTree Tests HTML Tags: del, dfn, img, menu, ol, option, q, source Aria role: alert, img, timer Aria state/property: aria-readonly="false", aria-hidden="false" BUG=170582 Committed: https://crrev.com/baa385c24c57df62f64a5f1fecee739dc2dcc3ba Cr-Commit-Position: refs/heads/master@{#293692}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Adding expected results on win and mac #

Total comments: 8

Patch Set 3 : Processed Comments #

Patch Set 4 : Modifying aria-readonly.html #

Total comments: 3

Patch Set 5 : Adding aria-readonly expected for win #

Patch Set 6 : #

Patch Set 7 : Uploading expected txt file for aria-hidden #

Patch Set 8 : Adding skip for aria-readonly expectations #

Patch Set 9 : #

Patch Set 10 : fixing aria-readonly #

Patch Set 11 : Adding aria-readonly expectation for mac #

Patch Set 12 : Adding expectations for android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -5 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 4 5 8 chunks +55 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-alert.html View 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-alert-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-alert-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-alert-expected-win.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-hidden.html View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-hidden-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-hidden-expected-mac.txt View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-hidden-expected-win.txt View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-img.html View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-img-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/aria-img-expected-mac.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-img-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/aria-readonly.html View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-readonly-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-readonly-expected-mac.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-readonly-expected-win.txt View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-timer.html View 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-timer-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-timer-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-timer-expected-win.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/del.html View 1 chunk +3 lines, -1 line 0 comments Download
A content/test/data/accessibility/del-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/del-expected-mac.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/del-expected-win.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/dfn.html View 1 chunk +7 lines, -0 lines 0 comments Download
A content/test/data/accessibility/dfn-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/dfn-expected-mac.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/dfn-expected-win.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/menu-type-context.html View 1 chunk +16 lines, -0 lines 0 comments Download
A content/test/data/accessibility/menu-type-context-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/menu-type-context-expected-mac.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/menu-type-context-expected-win.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/ol.html View 1 1 chunk +18 lines, -0 lines 0 comments Download
A content/test/data/accessibility/ol-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +21 lines, -0 lines 0 comments Download
A content/test/data/accessibility/ol-expected-mac.txt View 1 1 chunk +21 lines, -0 lines 0 comments Download
A content/test/data/accessibility/ol-expected-win.txt View 1 1 chunk +21 lines, -0 lines 0 comments Download
A content/test/data/accessibility/option-in-datalist.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/option-in-datalist-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/option-in-datalist-expected-mac.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/option-in-datalist-expected-win.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/q.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
A content/test/data/accessibility/q-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/q-expected-mac.txt View 1 1 chunk +7 lines, -0 lines 0 comments Download
A content/test/data/accessibility/q-expected-win.txt View 1 1 chunk +7 lines, -0 lines 0 comments Download
A content/test/data/accessibility/source.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/source-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +7 lines, -0 lines 0 comments Download
A content/test/data/accessibility/source-expected-mac.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
A content/test/data/accessibility/source-expected-win.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
A content/test/data/accessibility/sub.html View 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/sub-expected-android.txt View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/sub-expected-mac.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/sub-expected-win.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (5 generated)
shreeramk
Could you please suggest me the changes? Thanks!
6 years, 4 months ago (2014-08-25 11:45:43 UTC) #1
dmazzoni
https://codereview.chromium.org/496313003/diff/1/content/browser/accessibility/aria-readonly.html File content/browser/accessibility/aria-readonly.html (right): https://codereview.chromium.org/496313003/diff/1/content/browser/accessibility/aria-readonly.html#newcode3 content/browser/accessibility/aria-readonly.html:3: <div role="textbox" aria-readonly="false" tabindex="0">readonly=false</div> I'd suggest one example with ...
6 years, 4 months ago (2014-08-25 15:00:18 UTC) #2
shreeramk
from now onwards, I ll take care of all the values of a particular state ...
6 years, 4 months ago (2014-08-25 15:36:57 UTC) #3
shreeramk
PTAL :) Thanks!
6 years, 3 months ago (2014-08-26 12:47:38 UTC) #4
dmazzoni
Thanks for this contribution! https://codereview.chromium.org/496313003/diff/20001/content/browser/accessibility/aria-readonly.html File content/browser/accessibility/aria-readonly.html (right): https://codereview.chromium.org/496313003/diff/20001/content/browser/accessibility/aria-readonly.html#newcode6 content/browser/accessibility/aria-readonly.html:6: <div role="textbox" aria-readonly="false" tabindex="0">This tests ...
6 years, 3 months ago (2014-08-26 15:18:59 UTC) #5
shreeramk
All comments has been taken care in this patch set, except one for del.html The ...
6 years, 3 months ago (2014-08-27 07:36:22 UTC) #6
shreeramk
PTAL! Still I am getting the same expected result for aria-readonly on mac and win.
6 years, 3 months ago (2014-08-27 12:47:31 UTC) #7
shreeramk
On 2014/08/27 12:47:31, shreeram.k wrote: > PTAL! > > Still I am getting the same ...
6 years, 3 months ago (2014-09-03 17:26:59 UTC) #8
dmazzoni
I think this is done once the aria-hidden expectations are in! https://codereview.chromium.org/496313003/diff/60001/content/test/data/accessibility/aria-hidden.html File content/test/data/accessibility/aria-hidden.html (right): ...
6 years, 3 months ago (2014-09-03 21:30:02 UTC) #9
dmazzoni
https://codereview.chromium.org/496313003/diff/60001/content/browser/accessibility/aria-readonly.html File content/browser/accessibility/aria-readonly.html (right): https://codereview.chromium.org/496313003/diff/60001/content/browser/accessibility/aria-readonly.html#newcode6 content/browser/accessibility/aria-readonly.html:6: <input aria-readonly="false" tabindex="0" value="Editable text">This test is for aria-readonly=false</div> ...
6 years, 3 months ago (2014-09-03 21:31:53 UTC) #10
shreeramk
PTAL! For aria-hidden.html, I have uploaded the expected file on win and mac. For aria-readonly, ...
6 years, 3 months ago (2014-09-04 13:38:58 UTC) #11
dmazzoni
lgtm OK, please just put the "skip" line in the expectation files for aria-readonly, and ...
6 years, 3 months ago (2014-09-04 15:08:38 UTC) #12
dmazzoni
To clarify, please feel free to commit once try jobs pass. Just skip any test ...
6 years, 3 months ago (2014-09-04 15:09:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shreeram.k@samsung.com/496313003/200001
6 years, 3 months ago (2014-09-05 13:21:45 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/5684)
6 years, 3 months ago (2014-09-05 15:28:28 UTC) #17
dmazzoni
You need -expected-android.txt files. It's fine with me if you leave those all as "skip", ...
6 years, 3 months ago (2014-09-05 15:45:44 UTC) #18
shreeramk
On 2014/09/05 15:45:44, dmazzoni wrote: > You need -expected-android.txt files. It's fine with me if ...
6 years, 3 months ago (2014-09-05 16:36:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shreeram.k@samsung.com/496313003/220001
6 years, 3 months ago (2014-09-08 04:55:46 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shreeram.k@samsung.com/496313003/220001
6 years, 3 months ago (2014-09-08 07:24:35 UTC) #24
commit-bot: I haz the power
Committed patchset #12 (id:220001) as 3b2c2a21c4d6b6c840c287e6231e084fffbb77f4
6 years, 3 months ago (2014-09-08 09:19:27 UTC) #25
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:17 UTC) #26
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/baa385c24c57df62f64a5f1fecee739dc2dcc3ba
Cr-Commit-Position: refs/heads/master@{#293692}

Powered by Google App Engine
This is Rietveld 408576698