Issue 496313002: Remove KeyedStoreIC::GenerateRuntimeSetProperty and move Store::GenerateRuntimeSetProperty to the P…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 496313002: Remove KeyedStoreIC::GenerateRuntimeSetProperty and move Store::GenerateRuntimeSetProperty to the P… (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Remove KeyedStoreIC::GenerateRuntimeSetProperty and move Store::GenerateRuntimeSetProperty to the PropertyICCompiler BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23311

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -130 lines)			Patch
M	src/ic/arm/ic-arm.cc	View	4 chunks	+2 lines, -25 lines	0 comments	Download
M	src/ic/arm/ic-compiler-arm.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/ic/arm64/ic-arm64.cc	View	4 chunks	+2 lines, -30 lines	0 comments	Download
M	src/ic/arm64/ic-compiler-arm64.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/ic/ia32/ic-compiler-ia32.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/ic/ia32/ic-ia32.cc	View	3 chunks	+2 lines, -35 lines	0 comments	Download
M	src/ic/ic.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/ic/ic-compiler.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/ic/ic-compiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ic/x64/ic-compiler-x64.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/ic/x64/ic-x64.cc	View	3 chunks	+2 lines, -37 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

6 years, 4 months ago (2014-08-22 12:48:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23311 (presubmit successful).