Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 496253002: Remove dependency on GCTrace from GCIdleTimeHandler. (Closed)

Created:
6 years, 4 months ago by ulan
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove dependency on GCTrace from GCIdleTimeHandler. This makes testing GCIdleTimeHandler easier. BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23314

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 3 chunks +6 lines, -9 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
6 years, 4 months ago (2014-08-22 09:48:15 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 4 months ago (2014-08-22 09:58:02 UTC) #2
ulan
6 years, 4 months ago (2014-08-22 13:02:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 23314 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698