Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 496203002: Pepper: PPB_VideoDecoder software-only mode. (Closed)

Created:
6 years, 4 months ago by bbudge
Modified:
6 years, 3 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, jam, raymes+watch_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, Sam Clegg, ihf+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Pepper: PPB_VideoDecoder software-only mode. Add 'Initialize' method that takes an enum value to specify hardware acceleration policy. Policies are always, with fallback and only software. BUG=406194 Committed: https://crrev.com/4d6acafdc75e94256ab7c75f2f3e8a46e42bb9ec Cr-Commit-Position: refs/heads/master@{#291606}

Patch Set 1 : #

Patch Set 2 : Fix cpp comments #

Total comments: 8

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -70 lines) Patch
M content/renderer/pepper/pepper_video_decoder_host.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_video_decoder_host.cc View 1 2 2 chunks +14 lines, -13 lines 0 comments Download
M native_client_sdk/src/examples/api/video_decode/video_decode.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/api/pp_codecs.idl View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M ppapi/api/ppb_video_decoder.idl View 1 2 2 chunks +30 lines, -1 line 0 comments Download
M ppapi/c/pp_codecs.h View 1 2 2 chunks +17 lines, -1 line 0 comments Download
M ppapi/c/pp_macros.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/c/ppb_video_decoder.h View 1 2 6 chunks +30 lines, -6 lines 0 comments Download
M ppapi/cpp/video_decoder.h View 1 2 3 chunks +6 lines, -9 lines 0 comments Download
M ppapi/cpp/video_decoder.cc View 1 2 6 chunks +39 lines, -3 lines 0 comments Download
M ppapi/examples/video_decode/video_decode.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 5 chunks +63 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/proxy/video_decoder_resource.h View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M ppapi/proxy/video_decoder_resource.cc View 1 2 2 chunks +15 lines, -2 lines 0 comments Download
M ppapi/proxy/video_decoder_resource_unittest.cc View 8 chunks +8 lines, -9 lines 0 comments Download
M ppapi/tests/test_video_decoder.cc View 4 chunks +15 lines, -14 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev_channel.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/thunk/ppb_video_decoder_api.h View 1 chunk +6 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_video_decoder_thunk.cc View 5 chunks +34 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
bbudge
6 years, 4 months ago (2014-08-22 16:59:47 UTC) #1
bbudge
+Tom for IPC changes
6 years, 4 months ago (2014-08-22 17:00:21 UTC) #2
bbudge
+Ben for NaCl SDK
6 years, 4 months ago (2014-08-22 17:00:51 UTC) #3
dmichael (off chromium)
Punting to teravest@; I've been too overload
6 years, 4 months ago (2014-08-22 17:09:41 UTC) #4
Tom Sepez
LGTM with nit. https://codereview.chromium.org/496203002/diff/60001/ppapi/api/pp_codecs.idl File ppapi/api/pp_codecs.idl (right): https://codereview.chromium.org/496203002/diff/60001/ppapi/api/pp_codecs.idl#newcode41 ppapi/api/pp_codecs.idl:41: }; nit: generally, the patter is ...
6 years, 4 months ago (2014-08-22 17:13:01 UTC) #5
binji
native_client_sdk lgtm
6 years, 4 months ago (2014-08-22 17:18:18 UTC) #6
teravest
https://codereview.chromium.org/496203002/diff/60001/ppapi/api/ppb_video_decoder.idl File ppapi/api/ppb_video_decoder.idl (right): https://codereview.chromium.org/496203002/diff/60001/ppapi/api/ppb_video_decoder.idl#newcode103 ppapi/api/ppb_video_decoder.idl:103: * @param[in] hardware_acceleration A <code>PP_HardwareAcceleration</code> nit: The parameter name ...
6 years, 4 months ago (2014-08-22 18:32:37 UTC) #7
bbudge
https://codereview.chromium.org/496203002/diff/60001/ppapi/api/pp_codecs.idl File ppapi/api/pp_codecs.idl (right): https://codereview.chromium.org/496203002/diff/60001/ppapi/api/pp_codecs.idl#newcode41 ppapi/api/pp_codecs.idl:41: }; On 2014/08/22 17:13:01, Tom Sepez wrote: > nit: ...
6 years, 4 months ago (2014-08-22 21:24:53 UTC) #8
teravest
lgtm
6 years, 4 months ago (2014-08-22 21:25:56 UTC) #9
bbudge
The CQ bit was checked by bbudge@chromium.org
6 years, 4 months ago (2014-08-23 01:02:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/496203002/80001
6 years, 4 months ago (2014-08-23 04:56:32 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-23 07:52:28 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (80001) as 6e08f20e6a642d0bda851728ba6306f2d383145b
6 years, 4 months ago (2014-08-23 22:17:53 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:32:00 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4d6acafdc75e94256ab7c75f2f3e8a46e42bb9ec
Cr-Commit-Position: refs/heads/master@{#291606}

Powered by Google App Engine
This is Rietveld 408576698