Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 496183003: Let benchmark runner add summary traces. (Closed)

Created:
6 years, 3 months ago by Michael Achenbach
Modified:
6 years, 3 months ago
Reviewers:
Jarin, Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Let benchmark runner add summary traces. BUG=374740 LOG=n R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23493

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2 lines) Patch
M tools/run_benchmarks.py View 1 5 chunks +36 lines, -2 lines 0 comments Download
M tools/unittests/run_benchmarks_test.py View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
machenbach@chromium.org changed reviewers: + jarin@chromium.org, jkummerow@chromium.org
6 years, 3 months ago (2014-08-27 14:22:34 UTC) #1
Michael Achenbach
PTAL
6 years, 3 months ago (2014-08-27 14:35:24 UTC) #2
Jarin
lgtm
6 years, 3 months ago (2014-08-28 13:45:01 UTC) #3
Michael Achenbach
6 years, 3 months ago (2014-08-28 14:42:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 23493 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698