Issue 496173002: Revert of Revert back to SkPictureData pictures. Huge perf regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 496173002: Revert of Revert back to SkPictureData pictures. Huge perf regression. (Closed)

Created:
6 years, 4 months ago by mtklein

Modified:
6 years, 4 months ago

Reviewers:
mtklein_C, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Revert back to SkPictureData pictures. Huge perf regression. (patchset #1 of https://codereview.chromium.org/496603002/) Reason for revert: Try again now that we have --bbh on nanobench and it's looking decent. Original issue's description: > Revert back to SkPictureData pictures. Huge perf regression. > > http://skiaperf.com/#108 > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4082d290eea2f70caa82120ff3bc4fbdccbf206c TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c8c4b957288fd3114d60e3faa9bc95c4c15ca1f2

Created: 6 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	src/core/SkPicture.cpp	View		2 chunks	+0 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Revert back to SkPictureData pictures. Huge perf regression.

6 years, 4 months ago (2014-08-22 00:10:03 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/496173002/1

6 years, 4 months ago (2014-08-22 00:10:11 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-08-22 00:10:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (1) as c8c4b957288fd3114d60e3faa9bc95c4c15ca1f2