Issue 49613005: Have TreeScrope::adoptIfNeeded() take a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49613005: Have TreeScrope::adoptIfNeeded() take a reference instead of a pointer (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
adamk

CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Have TreeScrope::adoptIfNeeded() take a reference instead of a pointer Have TreeScrope::adoptIfNeeded() take a reference instead of a pointer as it expects the argument to be non-null. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160851

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -63 lines)			Patch
M	Source/core/dom/Attr.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/ContainerNode.cpp	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/dom/ContainerNodeAlgorithms.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/TreeScope.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/TreeScope.cpp	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	Source/core/dom/TreeScopeAdopter.h	View	2 chunks	+10 lines, -12 lines	0 comments	Download
M	Source/core/dom/TreeScopeAdopter.cpp	View	3 chunks	+31 lines, -32 lines	0 comments	Download
M	Source/core/dom/shadow/ShadowRoot.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLTemplateElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

adamk

lgtm I especially like replacing the ".get()" suffix with a "*" prefix as this patch ...

7 years, 1 month ago (2013-10-29 15:47:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/49613005/1

7 years, 1 month ago (2013-10-29 16:36:12 UTC) #3

Message was sent while issue was closed.

Change committed as 160851

Expand Messages | Collapse Messages