Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 49613003: Revert 231456 "Remove ninja special cases for iOS build configur..." (Closed)

Created:
7 years, 1 month ago by rmsousa
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 231456 "Remove ninja special cases for iOS build configur..." This broke the "iOS Device" bot. > Remove ninja special cases for iOS build configurations. > > Gyp now sets -iphoneos architecture, so armv7 switching isn't required in > common.gypi. This CL also gets rid of ONLY_ACTIVE_ARCH, which requires full > rebuilds when switching devices between armv7, armv7s and arm64 devices. > > Also remove the iOS5 arclite link step, which isn't needed in iOS6+. > > BUG=312300 > Test=ios_rel_device builds > > Review URL: https://codereview.chromium.org/25535004 TBR=justincohen@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -16 lines) Patch
M trunk/src/build/common.gypi View 6 chunks +113 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rmsousa
7 years, 1 month ago (2013-10-29 00:55:10 UTC) #1
rmsousa
7 years, 1 month ago (2013-10-29 00:55:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r231466.

Powered by Google App Engine
This is Rietveld 408576698