Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 496123003: win: Don't VIEWS_EXPORT ImagePainter. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/0a2bace14d3d31541fed7cb15bae4f9f49b64f94 Cr-Commit-Position: refs/heads/master@{#291950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/painter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
thakis@chromium.org changed reviewers: + msw@chromium.org
6 years, 4 months ago (2014-08-26 03:34:18 UTC) #1
Nico
6 years, 4 months ago (2014-08-26 03:34:18 UTC) #2
msw
lgtm, thanks!
6 years, 3 months ago (2014-08-26 18:31:30 UTC) #3
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 3 months ago (2014-08-26 18:31:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/496123003/1
6 years, 3 months ago (2014-08-26 18:33:48 UTC) #5
Nico
Committed patchset #1 to pending queue manually as ad1df6b (presubmit successful).
6 years, 3 months ago (2014-08-26 18:57:41 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:44:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a2bace14d3d31541fed7cb15bae4f9f49b64f94
Cr-Commit-Position: refs/heads/master@{#291950}

Powered by Google App Engine
This is Rietveld 408576698