Fix the ownership of media_log_ in WebMediaPlayerAndroid

content/renderer/media/android/webmediaplayer_android.h

Index: content/renderer/media/android/webmediaplayer_android.h
diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h
index 3e8530f083b67533f4d265a224081bc65adac1e4..1fd84b95ba72570897f0b9857d9ca50a105fdace 100644
--- a/content/renderer/media/android/webmediaplayer_android.h
+++ b/content/renderer/media/android/webmediaplayer_android.h
@@ -451,7 +451,7 @@ class WebMediaPlayerAndroid : public blink::WebMediaPlayer,
   // Whether the browser is currently connected to a remote media player.
   bool is_remote_;
 
-  media::MediaLog* media_log_;
+  scoped_refptr<media::MediaLog> media_log_;

[xhwang, 2014/08/21 22:40:28]

Since now WMPA partially owns media_log_, does it make sense to move this up
(before l.437) so that during destruction media_source_delegate_ won't use
media_log_ after media_log_ is already destructed?

[qinmin, 2014/08/22 01:03:59]

Currently, we pass a raw pointer to media_source_delegate_ and let
media_source_delegate_ taking the ownership. This will leak this pointer for
non-MSE case.
So if both webmediaplayerandroid and MediaSourceDelegate references the
media_log_, reference counting will release the pointer when both WMPA and MSD
are destroyed. As a result, putting media_log_ in front of
media_source_delegate_ doesn't help, since the pointer will still hanging around
until media_source_delegate_ gets deleted .  
Modified the code to pass a refptr instead of a raw pointer to MSD.
Or, alternatively, we can call swap inside MSD. In that case, WMPA will no
longer own the ptr in MSE case, and owns it in non-MSE case.
On 2014/08/21 22:40:28, xhwang wrote:

 
   scoped_ptr<MediaInfoLoader> info_loader_;