Issue 49603003: Check for import from previous script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49603003: Check for import from previous script. (Closed)

Created:
7 years, 1 month ago by vsm

Modified:
7 years, 1 month ago

Reviewers:
siva

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit

Visibility:
Public.

More Reviews

Description

Check for import from previous script. If we hit two script tags: <script src="a.dart"></script> <script src="b.dart"></script> and a.dart imports b.dart, we need to not reload b.dart into the VM. R=asiva@google.com Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1493

Patch Set 1 #

Total comments: 2

Patch Set 2 : Hoist partially redundant check #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	Source/bindings/dart/DartApplicationLoader.cpp	View	1	1 chunk	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/49603003/diff/1/Source/bindings/dart/DartApplicationLoader.cpp File Source/bindings/dart/DartApplicationLoader.cpp (right): https://chromiumcodereview.appspot.com/49603003/diff/1/Source/bindings/dart/DartApplicationLoader.cpp#newcode191 Source/bindings/dart/DartApplicationLoader.cpp:191: DartUtilities::reportProblem(m_originDocument, library, m_libraryUrl); This Dart_IsError(library) error check should ...

7 years, 1 month ago (2013-10-28 19:52:41 UTC) #2

vsm

Committed patchset #2 manually as r1493 (presubmit successful).

7 years, 1 month ago (2013-10-28 19:58:29 UTC) #3

vsm

7 years, 1 month ago (2013-10-28 19:58:41 UTC) #4

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/49603003/diff/1/Source/bindings/dart/D...
File Source/bindings/dart/DartApplicationLoader.cpp (right):

https://chromiumcodereview.appspot.com/49603003/diff/1/Source/bindings/dart/D...
Source/bindings/dart/DartApplicationLoader.cpp:191:
DartUtilities::reportProblem(m_originDocument, library, m_libraryUrl);
On 2013/10/28 19:52:42, siva wrote:
> This Dart_IsError(library) error check should also be inside
> if (Dart_IsError(library)) {
>   ...
>   ...
> }

Done.

Expand Messages | Collapse Messages