Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5919)

Unified Diff: chrome/common/process_watcher_posix.cc

Issue 496007: Make ProcessWatcher use kqueues on Mac. (Closed)
Patch Set: No need for a thread Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/process_watcher_mac.cc ('k') | chrome/common/process_watcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/process_watcher_posix.cc
diff --git a/chrome/common/process_watcher_posix.cc b/chrome/common/process_watcher_posix.cc
index afe6fe556a883c88803746c5a3cd1681b7b93bbd..c0ea178d2c8c81a814d40a0f20400efd94ae7f74 100644
--- a/chrome/common/process_watcher_posix.cc
+++ b/chrome/common/process_watcher_posix.cc
@@ -46,8 +46,8 @@ class BackgroundReaper : public PlatformThread::Delegate {
if (timeout_ == 0) {
pid_t r = HANDLE_EINTR(waitpid(child_, NULL, 0));
if (r != child_) {
- LOG(ERROR) << "While waiting for " << child_
- << " to terminate, we got the following result: " << r;
+ PLOG(ERROR) << "While waiting for " << child_
+ << " to terminate, we got the following result: " << r;
}
return;
}
@@ -83,7 +83,7 @@ class BackgroundReaper : public PlatformThread::Delegate {
// static
void ProcessWatcher::EnsureProcessTerminated(base::ProcessHandle process) {
- // If the child is already dead, then there's nothing to do
+ // If the child is already dead, then there's nothing to do.
if (IsChildDead(process))
return;
@@ -94,7 +94,7 @@ void ProcessWatcher::EnsureProcessTerminated(base::ProcessHandle process) {
// static
void ProcessWatcher::EnsureProcessGetsReaped(base::ProcessHandle process) {
- // If the child is already dead, then there's nothing to do
+ // If the child is already dead, then there's nothing to do.
if (IsChildDead(process))
return;
« no previous file with comments | « chrome/common/process_watcher_mac.cc ('k') | chrome/common/process_watcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698