Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: chrome/common/process_watcher.h

Issue 496007: Make ProcessWatcher use kqueues on Mac. (Closed)
Patch Set: No need for a thread Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/common/process_watcher_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/process_watcher.h
diff --git a/chrome/common/process_watcher.h b/chrome/common/process_watcher.h
index a1f909cd818b935d5839509f7ea86cafa81d2ff5..54b344bd923fbf3a144420136ec88d1bd42e5df4 100644
--- a/chrome/common/process_watcher.h
+++ b/chrome/common/process_watcher.h
@@ -20,14 +20,15 @@ class ProcessWatcher {
// does not appear to have exited, then this function starts to become
// aggressive about ensuring that the process terminates.
//
- // This method does not block the calling thread.
+ // On Linux this method does not block the calling thread.
+ // On OS X this method may block for up to 2 seconds.
//
// NOTE: The process handle must have been opened with the PROCESS_TERMINATE
// and SYNCHRONIZE permissions.
//
static void EnsureProcessTerminated(base::ProcessHandle process_handle);
-#if defined(OS_POSIX)
+#if defined(OS_LINUX)
// The nicer version of EnsureProcessTerminated() that is patient and will
// wait for |process_handle| to finish and then reap it.
static void EnsureProcessGetsReaped(base::ProcessHandle process_handle);
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | chrome/common/process_watcher_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698