Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 496006: Make KeywordEditorCocoaController implement the proper protocols. Also remove (Closed)

Created:
11 years ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Make KeywordEditorCocoaController implement the proper protocols. Also remove unnecessary ones from FontLanguageSettingsController. BUG=30155 TEST=Build with 10.6 SDK. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/cocoa/font_language_settings_controller.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/cocoa/keyword_editor_cocoa_controller.h View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert Sesek
11 years ago (2009-12-12 17:20:42 UTC) #1
Mark Mentovai
11 years ago (2009-12-13 15:58:24 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698