Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 495993002: Disable garbage collection for gyp_chromium. (Closed)

Created:
6 years, 4 months ago by Joao da Silva
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Disable garbage collection for gyp_chromium. Python always does reference counting and that handles most of the objects used by GYP. The GC is used to detect and drop circular references. If GC is turned off then the heap scanning can be skipped to save some CPU cycles, and the memory leaked due to circular references isn't noticeable. This saves about 1 second out of 16 on Linux in a Z620 workstation. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291287

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/gyp_chromium View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Joao da Silva
Hey Brett, can you have a look? Turns out that this idea gives a little ...
6 years, 4 months ago (2014-08-21 14:54:59 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-21 19:46:37 UTC) #2
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 4 months ago (2014-08-21 21:32:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/495993002/20001
6 years, 4 months ago (2014-08-21 21:36:40 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 23:04:59 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 01:07:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291287

Powered by Google App Engine
This is Rietveld 408576698