Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: media/audio/audio_manager_base.h

Issue 495983002: Improve logging related to start/stop and failure of audio input streams in Chrome (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Experimental version of AudioManagerBase logging Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_manager_base.h
diff --git a/media/audio/audio_manager_base.h b/media/audio/audio_manager_base.h
index bc13ee5a1677b46c89d08d47321b23bcd59606d8..b6fe07769d863bc34ba59e00517026eaf64b5861 100644
--- a/media/audio/audio_manager_base.h
+++ b/media/audio/audio_manager_base.h
@@ -102,6 +102,11 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager {
virtual void RemoveOutputDeviceChangeListener(
AudioDeviceListener* listener) OVERRIDE;
+ // TODO ----
Henrik Grunell 2014/08/22 16:14:43 Add text to comment or remove.
henrika (OOO until Aug 14) 2014/08/25 12:47:45 Renamed and improved. Will need second opinion if
+ virtual void AddStateChangeListener(StateChangeListener* listener) OVERRIDE;
+ virtual void RemoveStateChangeListener(
+ StateChangeListener* listener) OVERRIDE;
+
virtual AudioParameters GetDefaultOutputStreamParameters() OVERRIDE;
virtual AudioParameters GetOutputStreamParameters(
const std::string& device_id) OVERRIDE;
@@ -135,6 +140,8 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager {
// thread.
void NotifyAllOutputDeviceChangeListeners();
+ void NotifyAllStateChangeListeners(const std::string& msg);
+
// Returns user buffer size as specified on the command line or 0 if no buffer
// size has been specified.
int GetUserBufferSize();
@@ -179,6 +186,9 @@ class MEDIA_EXPORT AudioManagerBase : public AudioManager {
// Track output state change listeners.
ObserverList<AudioDeviceListener> output_listeners_;
+ // Track .....
Henrik Grunell 2014/08/22 16:14:43 Track down pink ducks? Tracks with Kaj Kindwall? S
henrika (OOO until Aug 14) 2014/08/25 12:47:45 Will improve ;-)
+ ObserverList<StateChangeListener> state_listeners_;
+
// Thread used to interact with audio streams created by this audio manager.
base::Thread audio_thread_;

Powered by Google App Engine
This is Rietveld 408576698