Improve logging related to start/stop and failure of audio input streams in Chrome

content/renderer/media/audio_input_message_filter.cc

Index: content/renderer/media/audio_input_message_filter.cc
diff --git a/content/renderer/media/audio_input_message_filter.cc b/content/renderer/media/audio_input_message_filter.cc
index 412196cb3c1fb9d936c07426c65416cff320fa13..c031bdead7897dfd74bc3b6aa0be76bc71ef45e9 100644
--- a/content/renderer/media/audio_input_message_filter.cc
+++ b/content/renderer/media/audio_input_message_filter.cc
@@ -12,6 +12,16 @@
 #include "ipc/ipc_logging.h"
 #include "ipc/ipc_sender.h"
 
+namespace {
+void LogMessage(int stream_id, std::string msg) {
+  std::string log_string =
+      base::StringPrintf("[stream_id=%d] AIMF::", stream_id);
+  log_string += msg;
+  content::WebRtcLogMessage(log_string);
+  DVLOG(1) << log_string;
+}
+}
+
 namespace content {
 
 namespace {
@@ -125,10 +135,7 @@ void AudioInputMessageFilter::OnStreamCreated(
     uint32 length,
     uint32 total_segments) {
   DCHECK(io_message_loop_->BelongsToCurrentThread());
-
-  WebRtcLogMessage(base::StringPrintf(
-      "AIMF::OnStreamCreated. stream_id=%d",
-      stream_id));
+  LogMessage(stream_id, "OnStreamCreated");
 
 #if !defined(OS_WIN)
   base::SyncSocket::Handle socket_handle = socket_descriptor.fd;
@@ -193,6 +200,7 @@ void AudioInputMessageFilter::AudioInputIPCImpl::CreateStream(
   DCHECK(delegate);
 
   stream_id_ = filter_->delegates_.Add(delegate);
+  LogMessage(stream_id_, "CreateStream");

[no longer working on chromium, 2014/08/25 08:20:05]

Do we really need to log each operation? It seems to me the new loggings do not
add much value.

[henrika (OOO until Aug 14), 2014/08/25 12:47:44]

The idea was to add on all levels to ensure that we have the full path. Today, I
am assigned to several issues where we have no idea why audio does not work. I
am only trying to cover all angles here.

Is it OK if I keep it and add a TODO to remove when we know more?

 
   AudioInputHostMsg_CreateStream_Config config;
   config.params = params;
@@ -204,6 +212,7 @@ void AudioInputMessageFilter::AudioInputIPCImpl::CreateStream(
 
 void AudioInputMessageFilter::AudioInputIPCImpl::RecordStream() {
   DCHECK_NE(stream_id_, kStreamIDNotSet);
+  LogMessage(stream_id_, "RecordStream");

[no longer working on chromium, 2014/08/25 08:20:05]

ditto

[henrika (OOO until Aug 14), 2014/08/25 12:47:44]

see above

   filter_->Send(new AudioInputHostMsg_RecordStream(stream_id_));
 }
 
@@ -215,6 +224,7 @@ void AudioInputMessageFilter::AudioInputIPCImpl::SetVolume(double volume) {
 void AudioInputMessageFilter::AudioInputIPCImpl::CloseStream() {
   DCHECK(filter_->io_message_loop_->BelongsToCurrentThread());
   DCHECK_NE(stream_id_, kStreamIDNotSet);
+  LogMessage(stream_id_, "CloseStream");

[no longer working on chromium, 2014/08/25 08:20:05]

ditto

[henrika (OOO until Aug 14), 2014/08/25 12:47:44]

see above

   filter_->Send(new AudioInputHostMsg_CloseStream(stream_id_));
   filter_->delegates_.Remove(stream_id_);
   stream_id_ = kStreamIDNotSet;