Fix stale keyboard bounds on login screen

Fix stale keyboard bounds on login screen

BUG=401667
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291281

[Nikita (slow), 2014-08-21 09:07:44]

oshima@ - please review ash/wm/*

bshe@ - please review ui/keyboard/*

[bshe, 2014-08-21 12:25:54]

On 2014/08/21 09:07:44, Nikita (OOO Aug 22 - Sep 8) wrote:
> oshima@ - please review ash/wm/*
> 
> bshe@ - please review ui/keyboard/*

ui/keyboard lgtm

[oshima, 2014-08-21 15:32:50]

https://codereview.chromium.org/495923002/diff/20001/ash/wm/lock_layout_manag...
File ash/wm/lock_layout_manager_unittest.cc (right):

https://codereview.chromium.org/495923002/diff/20001/ash/wm/lock_layout_manag...
ash/wm/lock_layout_manager_unittest.cc:218: ShowKeyboard(false);
why turning on and off?

https://codereview.chromium.org/495923002/diff/20001/ash/wm/lock_layout_manag...
ash/wm/lock_layout_manager_unittest.cc:226: // affect how bounds are stored.
rotation should update the display bounds. Have you tried to get the display
bounds again?

[Nikita (slow), 2014-08-21 16:00:41]

https://codereview.chromium.org/495923002/diff/20001/ash/wm/lock_layout_manag...
File ash/wm/lock_layout_manager_unittest.cc (right):

https://codereview.chromium.org/495923002/diff/20001/ash/wm/lock_layout_manag...
ash/wm/lock_layout_manager_unittest.cc:218: ShowKeyboard(false);
On 2014/08/21 15:32:50, oshima wrote:
> why turning on and off? 

This is the way to reproduce this bug before the fix:
invalid keyboard bounds got cached and then LockWindowState used those to offset
maximized window even though keyboard is hidden.

https://codereview.chromium.org/495923002/diff/20001/ash/wm/lock_layout_manag...
ash/wm/lock_layout_manager_unittest.cc:226: // affect how bounds are stored.
On 2014/08/21 15:32:50, oshima wrote:
> rotation should update the display bounds. Have you tried to get the display
> bounds again?

I'm getting updated screen bounds:
screen_bounds = primary_display.bounds();

But window->GetBoundsInScreen() is not taking rotation into account.

[oshima, 2014-08-21 16:32:39]

https://codereview.chromium.org/495923002/diff/20001/ash/wm/lock_layout_manag...
File ash/wm/lock_layout_manager_unittest.cc (right):

https://codereview.chromium.org/495923002/diff/20001/ash/wm/lock_layout_manag...
ash/wm/lock_layout_manager_unittest.cc:218: ShowKeyboard(false);
On 2014/08/21 16:00:41, Nikita (OOO Aug 22 - Sep 8) wrote:
> On 2014/08/21 15:32:50, oshima wrote:
> > why turning on and off? 
> 
> This is the way to reproduce this bug before the fix:
> invalid keyboard bounds got cached and then LockWindowState used those to
offset
> maximized window even though keyboard is hidden.

Can you mention that this is to repro a bug  (with bug#)

https://codereview.chromium.org/495923002/diff/20001/ash/wm/lock_layout_manag...
ash/wm/lock_layout_manager_unittest.cc:223: screen_bounds =
primary_display.bounds();
screen_bounds = Shell::GetScreen()->GetPrimaryDisplay()->bounds();

should work

[Nikita (slow), 2014-08-21 16:38:28]

https://codereview.chromium.org/495923002/diff/20001/ash/wm/lock_layout_manag...
File ash/wm/lock_layout_manager_unittest.cc (right):

https://codereview.chromium.org/495923002/diff/20001/ash/wm/lock_layout_manag...
ash/wm/lock_layout_manager_unittest.cc:218: ShowKeyboard(false);
On 2014/08/21 16:32:39, oshima wrote:
> On 2014/08/21 16:00:41, Nikita (OOO Aug 22 - Sep 8) wrote:
> > On 2014/08/21 15:32:50, oshima wrote:
> > > why turning on and off? 
> > 
> > This is the way to reproduce this bug before the fix:
> > invalid keyboard bounds got cached and then LockWindowState used those to
> offset
> > maximized window even though keyboard is hidden.
> 
> Can you mention that this is to repro a bug  (with bug#)

Done.

https://codereview.chromium.org/495923002/diff/20001/ash/wm/lock_layout_manag...
ash/wm/lock_layout_manager_unittest.cc:223: screen_bounds =
primary_display.bounds();
On 2014/08/21 16:32:39, oshima wrote:
> screen_bounds = Shell::GetScreen()->GetPrimaryDisplay()->bounds();
> 
> should work

Done.

[oshima, 2014-08-21 16:43:57]

lgtm

[oshima, 2014-08-21 16:46:42]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-08-21 16:49:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nkostylev@chromium.org/495923002/40001

[commit-bot: I haz the power, 2014-08-22 00:56:35]

Committed patchset #3 (40001) as 291281

[ranssesdp.RD, 2014-11-23 19:19:11]

ranssesdp.rd@gmail.com changed reviewers:
+ ranssesdp.RD@gmail.com

[ranssesdp.RD, 2014-11-23 19:19:12]

lgtm

[ranssesdp.RD, 2014-11-23 19:19:17]

lgtm

[ranssesdp.RD, 2014-11-23 19:19:30]

ranssesdp.rd@gmail.com changed reviewers:
+ ranssesdp.rd@gmail.com

[ranssesdp.RD, 2014-11-23 19:19:31]

lgtm

lgtm

[darrellthomas1977, 2015-07-15 17:06:23]

darrellthomas1977@googlemail.com changed reviewers:
+ darrellthomas1977@googlemail.com
- ranssesdp.RD@gmail.com

[darrellthomas1977, 2015-07-15 17:06:24]

lgtm

[brysnstokes82, 2017-02-02 10:09:21]

brysnstokes82@gmail.com changed reviewers:
+ brysnstokes82@gmail.com

[fewmemailove, 2017-03-31 23:26:44]

fewmemailove@gmail.com changed reviewers:
+ fewmemailove@gmail.com