Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: chrome/browser/extensions/user_script_loader.cc

Issue 495853002: Atomic UserScript ID generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/manifest_handlers/content_scripts_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/user_script_loader.cc
diff --git a/chrome/browser/extensions/user_script_loader.cc b/chrome/browser/extensions/user_script_loader.cc
index a25f9d25b583659a58731115660082498fb8c91e..eb29baea7f64ea8238ffcf3179c255a585d41c24 100644
--- a/chrome/browser/extensions/user_script_loader.cc
+++ b/chrome/browser/extensions/user_script_loader.cc
@@ -128,7 +128,7 @@ SubstitutionMap* GetLocalizationMessages(const ExtensionsInfo& extensions_info,
void LoadUserScripts(UserScriptList* user_scripts,
const ExtensionsInfo& extensions_info,
- const std::set<int64>& added_script_ids,
+ const std::set<int>& added_script_ids,
ContentVerifier* verifier) {
for (UserScriptList::iterator script = user_scripts->begin();
script != user_scripts->end();
@@ -202,7 +202,7 @@ scoped_ptr<base::SharedMemory> Serialize(const UserScriptList& scripts) {
void LoadScriptsOnFileThread(scoped_ptr<UserScriptList> user_scripts,
const ExtensionsInfo& extensions_info,
- const std::set<int64>& added_script_ids,
+ const std::set<int>& added_script_ids,
scoped_refptr<ContentVerifier> verifier,
LoadScriptsCallback callback) {
DCHECK(user_scripts.get());
@@ -333,7 +333,7 @@ bool UserScriptLoader::ParseMetadataHeader(const base::StringPiece& script_text,
// static
void UserScriptLoader::LoadScriptsForTest(UserScriptList* user_scripts) {
ExtensionsInfo info;
- std::set<int64> added_script_ids;
+ std::set<int> added_script_ids;
for (UserScriptList::iterator it = user_scripts->begin();
it != user_scripts->end();
++it) {
@@ -468,7 +468,7 @@ void UserScriptLoader::StartLoad() {
user_scripts_->insert(
user_scripts_->end(), added_scripts_.begin(), added_scripts_.end());
- std::set<int64> added_script_ids;
+ std::set<int> added_script_ids;
for (std::set<UserScript>::const_iterator it = added_scripts_.begin();
it != added_scripts_.end();
++it) {
« no previous file with comments | « no previous file | chrome/common/extensions/manifest_handlers/content_scripts_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698