Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 495803002: Revert of exclude BrowserOptionsOverlayWebUITest.testNavigationInBackground on drmemory bot (Closed)

Created:
6 years, 4 months ago by michaelpg
Modified:
6 years, 2 months ago
Reviewers:
oshima
CC:
bruening+watch_chromium.org, chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of exclude failing test BrowserOptionsOverlayWebUITest.testNavigationInBackground on drmemory bot (patchset #1 of https://codereview.chromium.org/470813002/) Reason for revert: Test has been patched. Original issue's description: > exclude failing test BrowserOptionsOverlayWebUITest.testNavigationInBackground on drmemory bot > > BUG=403627 > TBR=michaelpg@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289441 BUG=403627 Committed: https://crrev.com/975b48d92b63f1e71a4239e22d9e88cd7002463e Cr-Commit-Position: refs/heads/master@{#297260}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
michaelpg
Created Revert of exclude failing test BrowserOptionsOverlayWebUITest.testNavigationInBackground on drmemory bot
6 years, 4 months ago (2014-08-20 22:47:54 UTC) #1
michaelpg
Apparently browser_tests can't be tested on a DrMemory bot, and I haven't seen the test ...
6 years, 2 months ago (2014-09-29 18:53:06 UTC) #5
oshima
lgtm thank you for heads up.
6 years, 2 months ago (2014-09-29 18:59:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/495803002/140001
6 years, 2 months ago (2014-09-29 19:34:16 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:140001) as 9fa63babfa18af4a909fbf7beac8198341f42287
6 years, 2 months ago (2014-09-29 21:08:46 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 21:12:19 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/975b48d92b63f1e71a4239e22d9e88cd7002463e
Cr-Commit-Position: refs/heads/master@{#297260}

Powered by Google App Engine
This is Rietveld 408576698